Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False warning messages from .NET OPC UA client session #21

Closed
milankase opened this issue Mar 1, 2016 · 0 comments
Closed

False warning messages from .NET OPC UA client session #21

milankase opened this issue Mar 1, 2016 · 0 comments

Comments

@milankase
Copy link
Contributor

The method ProcessPublishResponse of the client session (Opc.Ua.Client.Session) probably generates false warning messages Sequence number={0} was not received in the available sequence numbers. The code that checks for the sequence numbers does not take into account the subscription id. If there is more than one subscription in the session then this code mixes up the sequence numbers from different sessions and issues the above mentioned message.

The code responsible:

foreach (var acknowledgement in acknowledgementsToSend)
{
    if (!availableSequenceNumbers.Contains(acknowledgement.SequenceNumber))
    {
        Utils.Trace("Sequence number={0} was not received in the available sequence numbers.", acknowledgement.SequenceNumber);
    }
}

Suggested fix:

    ...
    if (acknowledgement.SubscriptionId == subscriptionId && !availableSequenceNumbers.Contains(acknowledgement.SequenceNumber))
    {
    ...

Can anybody confirm?

This is follow-up to the forum thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants