-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake - proposal / WIP #172
Conversation
#include "../../cpucounters.h" | ||
#include "../../utils.h" | ||
#include "../cpucounters.h" | ||
#include "../utils.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can drop ../ if the directory is already in the includes fro include_directories()
@ahkok this is great! Thank you for making this proposal. cmake will really pay off if we can join two current Makefile (Linux/*BSD/OSX) and MSVC project files processes. BTW you can check your PR builds on OSX here: https://travis-ci.org/opcm/pcm/pull_requests |
I welcome changes in this direction, please continue with this, it is very much appreciated! |
Next I'll need to work on MSVC/Windows builds and Mac/BSD - Windows will be a little bit more complex. |
This won't yet fix MacOS builds just yet. CI isn't testing those either.
Not much progress today. Twiddled on MacOS builds yet but I think we may need to replace the xcodebuild section - I'm looking to see if there's examples where people have done similar things, but nothing came up yet. FWIW I think this will take a few weeks at least to iron out for MacOS and Windows. Given that I'm a Linux dev only I'll need to find some cross platform folks that can help with this. |
thanks. Now we have moved to cmake in the master branch. |
This is a shot across the bow to make this project easier to consume for everyone. With CMake, you can continue to use MSVC, build on Linux/Unix etc. And it will be much easier for consumers to actually use this software:
This makes packaging for all distributions trivial.
This is NOT finished. This is just an initial step showing how simple this can look if done right.
make install
also worksI've also reorganized the code to make sure there's no duplicate Cpp/H files around. Windows build may require a few more files to be moved to
src
and included in the build sequence, or otherwise fixed up.There's a ton more here that can and needs to be done, but I'd like @opcm folks to sniff at this and get warmed up for doing this change, since it will make the project trivial to consume for all customers (not just clearlinux users).
Note: this was ~ 3 hours of work. Please don't let this go to waste.