Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

剧集分组支持正片外的其它剧集 #492

Open
chivehao opened this issue Jun 25, 2024 · 5 comments
Open

剧集分组支持正片外的其它剧集 #492

chivehao opened this issue Jun 25, 2024 · 5 comments
Labels
M 重要优先级 s: media 子系统: 数据源基础 s: subject 子系统: 条目详情

Comments

@chivehao
Copy link
Contributor

chivehao commented Jun 25, 2024

子问题:


建议内容

剧集分组支持正片外的其它剧集,举个例子CLANNAD:

番组计划是有个23集的,但是因为不是正片,ani里找不到

番组计划条目
W$7TI8C`80%5N7W7$WL_(HJ

ani
@P6(UXG_L183WONA36` 7GE

建议:除了正片外,添加个比如Others的其它分组,
从番组计划拉取SP + 从数据源获取的数据源定义的番组计划没有的其它分组剧集

当前 Ani 版本号

3.2.0

操作系统

Windows

@chivehao chivehao added N 一般优先级 t: feature 类型: 新功能 labels Jun 25, 2024
@NeKoOuO
Copy link
Contributor

NeKoOuO commented Jun 25, 2024

提過了 #386

@Him188 Him188 added M 重要优先级 z: duplicate 状态: 重复问题 and removed N 一般优先级 labels Jun 25, 2024
@Him188 Him188 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@Him188 Him188 reopened this Jun 27, 2024
@Him188 Him188 added s: media 子系统: 数据源基础 s: subject 子系统: 条目详情 and removed z: duplicate 状态: 重复问题 labels Jun 27, 2024
@Him188
Copy link
Member

Him188 commented Jul 1, 2024

SP 剧集我看了一下, 允许获取比较简单, 但是要让整个 ani 全面支持比较麻烦, 你如果想要可以自己打个 patch

Subject: [PATCH] SP 剧集 (WIP)
---
Index: app/shared/src/commonMain/kotlin/data/repositories/BangumiEpisodeRepository.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/shared/src/commonMain/kotlin/data/repositories/BangumiEpisodeRepository.kt b/app/shared/src/commonMain/kotlin/data/repositories/BangumiEpisodeRepository.kt
--- a/app/shared/src/commonMain/kotlin/data/repositories/BangumiEpisodeRepository.kt	(revision a692e1dd9ab69edafae33a56251a972627d456b8)
+++ b/app/shared/src/commonMain/kotlin/data/repositories/BangumiEpisodeRepository.kt	(date 1719870036924)
@@ -10,6 +10,7 @@
 import me.him188.ani.datasources.api.EpisodeSort
 import me.him188.ani.datasources.api.paging.PageBasedPagedSource
 import me.him188.ani.datasources.api.paging.Paged
+import me.him188.ani.datasources.api.paging.filter
 import me.him188.ani.datasources.bangumi.BangumiClient
 import me.him188.ani.datasources.bangumi.models.BangumiEpType
 import me.him188.ani.datasources.bangumi.models.BangumiEpisode
@@ -83,7 +84,6 @@
             try {
                 client.api.getUserSubjectEpisodeCollection(
                     subjectId,
-                    episodeType = type,
                     offset = page * 100,
                     limit = 100,
                 ).body().run {
@@ -96,6 +96,8 @@
                 logger.warn("Exception in getSubjectEpisodeCollection", e)
                 null
             }
+        }.filter {
+            it.episode.type == 0 || it.episode.type == 1 // 本篇和SP
         }
         return episodes.results
     }

@Him188
Copy link
Member

Him188 commented Jul 1, 2024

全面支持需要考虑:

  • BT 搜资源
  • 测试 L1 对 SP 的支持 增加對有特典標題的資源判斷 #382
  • file selector 的支持
  • 选集播放里如何显示 SP
  • 播放器内剧集列表如何显示 SP
  • 标记看完时会弹窗选择设置所有剧集是否看过, 此时是否应当也设置 SP 为看过?
  • 序号会不会冲突, 例如正片 01 和 SP 01

@chivehao
Copy link
Contributor Author

怎么说呢,我的建议是直接在Media,加个字段比如isMain代表是否是正片。

  • BT 搜资源:直接忽略
  • file selector 的支持:正常剧集怎么选就怎么选
  • 选集播放里如何显示,正片放正片一栏,其它的放其它一栏
  • 播放器内剧集列表如何显示 SP:同上
  • 标记看完时会弹窗选择设置所有剧集是否看过, 此时是否应当也设置 SP 为看过?:不建议,这个可以加个可选配置,让用户自己选
  • 序号会不会冲突, 例如正片 01 和 SP 01:判断序号时,同时加上 isMain 的判断,类似联合主键

@Him188
Copy link
Member

Him188 commented Jul 17, 2024

EpisodeSort 支持 SP

@Him188 Him188 added t: meta issue 类型: 一类问题的综合归纳 and removed t: feature 类型: 新功能 labels Sep 2, 2024
@Him188 Him188 removed the t: meta issue 类型: 一类问题的综合归纳 label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M 重要优先级 s: media 子系统: 数据源基础 s: subject 子系统: 条目详情
Projects
None yet
Development

No branches or pull requests

3 participants