recalculate total funds available and spending totals on reset #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoclarke
approved these changes
Jul 1, 2017
|
@pvcarroll, That's a good point about total for the department not being set on load. I do think that should be the intended behavior, but I'm open to having my mind changed if we got that feedback. Right now, a user's values for each department start at 0. Once they are on a Department page and tap up or down, it obviously updates. Or if they click next, we set them at the amount from last year. So the user's selected value is effectively blank until they take some progressive action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159: After you reset, recalculate service amount and change remaining funds amount
Noticed that totals aren't set when the page loads - not sure if that was intended behavior or not.