Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate invitation manager service to portal #1326

Closed
wants to merge 7 commits into from

Conversation

RabiaSajjad
Copy link
Member

No description provided.

@wardi
Copy link
Member

wardi commented Sep 22, 2022

do we need this loaded on every page? what about adding it only on the required dataset pages instead?

@RabiaSajjad
Copy link
Member Author

do we need this loaded on every page? what about adding it only on the required dataset pages instead?

I understand you are concerned about performance. The assets (css/javascripts) won't load for any pages on the registry, I am overwriting the blocks on both base.html and page.html for internal templates to avoid loading invitation manager assets. On the portal, we only have dataset and resource pages which would load these assets. If you prefer, I can optimize it to load only for dataset pages.

@wardi
Copy link
Member

wardi commented Sep 23, 2022

IIRC the requirement was to have a survey on only specific departments' dataset pages and I don't think that can be done by applying the invitation manager to all pages on the site.
(Was also concerned it might appear in places like the frames of datastore views or other pages we're not expecting)

@RabiaSajjad
Copy link
Member Author

Replaced by #1495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants