Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch vault owner #555

Closed
2 tasks
pi0neerpat opened this issue Jun 1, 2024 · 3 comments
Closed
2 tasks

Fetch vault owner #555

pi0neerpat opened this issue Jun 1, 2024 · 3 comments
Assignees
Labels

Comments

@pi0neerpat
Copy link
Member

pi0neerpat commented Jun 1, 2024

Related to #508

Save the ownerAddress to state

  • In fetchSingleVaultData
  • When loading safes normally for the user
@pi0neerpat pi0neerpat changed the title Load owner data Fetch vault owner Jun 1, 2024
@jahabeebs
Copy link
Member

Related to #508

Save the ownerAddress to state

* [ ]  In `fetchSingleVaultData`

* [ ]  When loading safes normally for the user

@pi0neerpat When fetching vaults we only fetch it for the user and only hold those user's vaults in state--when a user views another user's vault then we're just fetching the single safe for that particular user. Are you saying you want to fetch the information for all the vaults in the protocol and hold that in the state?

  • [] In fetchSingleVaultData

This is fetched on demand when a user views someone else's vault--are you saying once they view that particular vault it should be stored in state for as long as possible?

  • [] When loading safes normally for the user

We only fetch the vaults a user already owns (so we know the owner, it's just the user's account). We don't load other vaults until they try viewing another person's vault

@jahabeebs
Copy link
Member

@pi0neerpat I sent this fix up to Iana's branch here, so I think we can close this. Now we can fetch any vault's owner regardless of if the wallet is connected or not. I added ownerAddress to the ISafe interface that we access via singleSafe

d02b182

Screenshots

Wallet not connected

Screenshot 2024-06-13 at 3 08 17 PM

Wallet connected

Screenshot 2024-06-13 at 3 08 42 PM

@pi0neerpat
Copy link
Member Author

Closed in #515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants