Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move to log/slog logging #260

Open
cndoit18 opened this issue Mar 25, 2024 · 2 comments
Open

[FEATURE] Move to log/slog logging #260

cndoit18 opened this issue Mar 25, 2024 · 2 comments
Labels
breaking-change Changes in exposed interfaces or behaviour enhancement New feature or request

Comments

@cndoit18
Copy link

cndoit18 commented Mar 25, 2024

Requirements

Now that structured logging has landed in the standard library, we can shed an external dependency and just use log/slog.

@cndoit18 cndoit18 added enhancement New feature or request Needs Triage labels Mar 25, 2024
@Kavindu-Dodan
Copy link
Contributor

@cndoit18 thank you for bringing this up. Currently, we use logr [1], and once we upgrade our Go version to 1.21, we could consider migrating/using the standard logger.

I will create a follow-up issue for 1.21 upgrade once we merge #255 [2]

[1] - https://github.com/open-feature/go-sdk?tab=readme-ov-file#logging
[2] - #255

@Kavindu-Dodan Kavindu-Dodan added breaking-change Changes in exposed interfaces or behaviour and removed Needs Triage labels Mar 25, 2024
@Kavindu-Dodan
Copy link
Contributor

Added breaking change tag as adoption of slog will break backward compatibility for older go versions. When implementing, we should consider interoperability with logr [1] and see if there're any API changes.

[1] - https://github.com/go-logr/logr?tab=readme-ov-file#slog-interoperability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes in exposed interfaces or behaviour enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants