Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datefield split inputs #457

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Datefield split inputs #457

merged 7 commits into from
Jun 28, 2023

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Jun 16, 2023 •
edited
Loading

Partially closes #433

  • Added input group component(s)
  • Added date field variant with input group widget
  • Restructured Storybook documentation for date field

@sergei-maertens sergei-maertens force-pushed the feature/433-datefield-split-inputs branch 6 times, most recently from 92f192f to 95847d7 Compare June 27, 2023 13:10
@sergei-maertens
✨ [#433] -- Implement an input group component
a953fc6 
The generic input group component can display related inputs inline,
with (presumably) accessible markup using the fieldset element.

It is required for the input-group variant/widget of the date field.
@sergei-maertens
⬆️ Bump to design tokens 0.35.0
397872f
@sergei-maertens sergei-maertens mentioned this pull request Jun 27, 2023
Closed
5 tasks
@sergei-maertens sergei-maertens force-pushed the feature/433-datefield-split-inputs branch from 95847d7 to ac6df5a Compare June 27, 2023 13:45
@sergei-maertens sergei-maertens marked this pull request as ready for review June 27, 2023 13:55
@sergei-maertens sergei-maertens mentioned this pull request Jun 27, 2023
Merged
CharString
CharString requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@CharString CharString left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. I've figured out how to give the widgets enough space in the mdx.
I could really use that workshop NLDS/design tokens. 🙂

src/components/forms/DateField/DateField-datepicker.mdx Outdated Show resolved Hide resolved
src/components/forms/DateField/DateField-datepicker.mdx Outdated Show resolved Hide resolved
@sergei-maertens
🚚 [#433] -- Re-organize date field stories/implementation
f84a523 
Split the stories and implementation by widget, tackling the datepicker
first and preparing for the input group variant.
@sergei-maertens
✨ [#433] -- implement a date field variant with input group
853bfa7 
Day, month and year can be entered individually, which is a more
accessible alternative for known dates than a date picker.

The order of the inputs also varies with the active locale, to align
best with expectations for individual users.
@sergei-maertens
🌐 [#433] -- update Dutch translations
c496a33
@sergei-maertens
💚 [#433] -- update appointment components
0f0c70b
@sergei-maertens
✅ [#433] -- added (interaction) tests for input group date field
98dd212
@sergei-maertens sergei-maertens force-pushed the feature/433-datefield-split-inputs branch from 133bfc2 to 98dd212 Compare June 28, 2023 07:03
@sergei-maertens sergei-maertens merged commit e1052f1 into main Jun 28, 2023
11 of 12 checks passed
@sergei-maertens sergei-maertens deleted the feature/433-datefield-split-inputs branch June 28, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharString CharString CharString requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datefield: next iteration
2 participants
@sergei-maertens @CharString