Add more fail checking of data #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2017 10:47
Danielhiversen
commented
Feb 14, 2017
| self._cache = None | ||
| return | ||
| if self._firmware_version >= "2.6.6": | ||
| if sum(self._cache[10:]) == 0: |
There was a problem hiding this comment.
I am not sure about the validity of this check.
I do not know the meaning of the data from index 10. But in all the test data I have achieved the values are above 0 when the values are valid. For invalid data the values are often 0.
|
@open-homeautomation Could you have a look at this one? |
|
@open-homeautomation |
|
I can't say anything about the validity check with byte 10, but I recommend, we put it in and see what feedback is reported from users. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more fail checking of data
Tested by myself and one user here: https://community.home-assistant.io/t/xiaomi-mi-plants-monitor-flower/3388/105?u=danielhiversen