[Fix] Fix pixel_decoder_type discrimination in MaskFormer Head.
#9176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @MengzhangLI Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below |
RangiLyu
reviewed
Oct 28, 2022
Li-Qingyun
previously approved these changes
Oct 31, 2022
RangiLyu
reviewed
Oct 31, 2022
ZwwWayne
pushed a commit
that referenced
this pull request
Nov 14, 2022
* [Fix]: fix wrong padding value in cached MixUp (#9259) * [Fix] Fix resume arg conflict. (#9287) * [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176) * [Fix] Fix pixel_decoder_type assertion in MaskFormer * use isinstance assertion * fix * fix inference demo Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com> Co-authored-by: RangiLyu <lyuchqi@gmail.com> Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
ZwwWayne
pushed a commit
that referenced
this pull request
Nov 23, 2022
* [Fix]: fix wrong padding value in cached MixUp (#9259) * [Enhance]: Add resume from specific checkpoint in CLI * [Fix] Fix resume arg conflict. (#9287) * [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176) * [Fix] Fix pixel_decoder_type assertion in MaskFormer * use isinstance assertion * fix * fix resume conflict * support both auto-resume and resume-from Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com> Co-authored-by: RangiLyu <lyuchqi@gmail.com> Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
ZwwWayne
added a commit
that referenced
this pull request
Nov 25, 2022
…9292) * [Fix]: fix wrong padding value in cached MixUp (#9259) * [Fix] Fix resume arg conflict. (#9287) * [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176) * [Fix] Fix pixel_decoder_type assertion in MaskFormer * use isinstance assertion * fix * fix faq * Apply suggestions from code review Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com> * fix format * fix format * fix faq.md * Update docs/en/notes/faq.md Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com> * 1123 * Update faq.md * fix format Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com> Co-authored-by: RangiLyu <lyuchqi@gmail.com> Co-authored-by: MengzhangLI <mcmong@pku.edu.cn> Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com> Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, MMDetection does not treat inter-codebases using modules very well. For example, in upstream codebase which
pip install mmdetand uses typemmdet.PixelDecoder, the error would happen in this line because thisif elsewould discriminatemmdet.PixelDecoderandPixelDecoderalthough they are the same.