[Fix] Fix resume arg conflict. #9287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhaAndroid
approved these changes
Nov 9, 2022
ZwwWayne
pushed a commit
that referenced
this pull request
Nov 14, 2022
ZwwWayne
pushed a commit
that referenced
this pull request
Nov 14, 2022
* [Fix]: fix wrong padding value in cached MixUp (#9259) * [Fix] Fix resume arg conflict. (#9287) * [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176) * [Fix] Fix pixel_decoder_type assertion in MaskFormer * use isinstance assertion * fix * fix inference demo Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com> Co-authored-by: RangiLyu <lyuchqi@gmail.com> Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
ZwwWayne
pushed a commit
that referenced
this pull request
Nov 23, 2022
* [Fix]: fix wrong padding value in cached MixUp (#9259) * [Enhance]: Add resume from specific checkpoint in CLI * [Fix] Fix resume arg conflict. (#9287) * [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176) * [Fix] Fix pixel_decoder_type assertion in MaskFormer * use isinstance assertion * fix * fix resume conflict * support both auto-resume and resume-from Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com> Co-authored-by: RangiLyu <lyuchqi@gmail.com> Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
ZwwWayne
added a commit
that referenced
this pull request
Nov 25, 2022
…9292) * [Fix]: fix wrong padding value in cached MixUp (#9259) * [Fix] Fix resume arg conflict. (#9287) * [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176) * [Fix] Fix pixel_decoder_type assertion in MaskFormer * use isinstance assertion * fix * fix faq * Apply suggestions from code review Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com> * fix format * fix format * fix faq.md * Update docs/en/notes/faq.md Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com> * 1123 * Update faq.md * fix format Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com> Co-authored-by: RangiLyu <lyuchqi@gmail.com> Co-authored-by: MengzhangLI <mcmong@pku.edu.cn> Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com> Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
If
args.resumeis None,cfg.resume = args.resumewill always setresumetoNoneeven if you setresume=Truein config or through--cfg-options.Modification
Only overwrite the cfg.resume when args.resume is not None.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist