Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: fix (Cached) MixUp padding #9259

Merged
merged 1 commit into from
Nov 8, 2022
Merged

[Fix]: fix (Cached) MixUp padding #9259

merged 1 commit into from
Nov 8, 2022

Conversation

plutoyuxie
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Nov 8, 2022

Hi @plutoyuxie ,
Thanks for your PR. Could you explain more.about the motivation of this PR, e.g., why do you need to change the padded part should be ones instead of zeros?

@RangiLyu RangiLyu added the v-3.x label Nov 8, 2022
@plutoyuxie
Copy link
Contributor Author

Hi @plutoyuxie , Thanks for your PR. Could you explain more.about the motivation of this PR, e.g., why do you need to change the padded part should be ones instead of zeros?

Dear @ZwwWayne,below is my motivation of this PR:

When I use browse_dataset.py to visual check CachedMixUp augmentation in my own project, some kind of artificial grey strips appeared.
The padded area is not filled with the given pad_val properly.
It is not clear in coco dataset, but very obvious when a x-ray dataset was used in my project, while the image background is white and pad_val=255.0 is needed in my case.

@ZwwWayne ZwwWayne merged commit 6bd0ae9 into open-mmlab:dev-3.x Nov 8, 2022
ZwwWayne pushed a commit that referenced this pull request Nov 14, 2022
* [Fix]: fix wrong padding value in cached MixUp (#9259)

* [Fix] Fix resume arg conflict. (#9287)

* [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176)

* [Fix] Fix pixel_decoder_type assertion in MaskFormer

* use isinstance assertion

* fix

* fix inference demo

Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com>
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
@ZwwWayne ZwwWayne added this to the 3.0.0rc4 milestone Nov 14, 2022
ZwwWayne pushed a commit that referenced this pull request Nov 15, 2022
* [Fix]: fix wrong padding value in cached MixUp (#9259)

* [Fix] type of "counts" in COCO’s compressed RLE 

counts in COCO’s compressed RLE format have type 'str' or 'list'

Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com>
ZwwWayne pushed a commit that referenced this pull request Nov 23, 2022
* [Fix]: fix wrong padding value in cached MixUp (#9259)

* [Enhance]: Add resume from specific checkpoint in CLI

* [Fix] Fix resume arg conflict. (#9287)

* [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176)

* [Fix] Fix pixel_decoder_type assertion in MaskFormer

* use isinstance assertion

* fix

* fix resume conflict

* support both auto-resume and resume-from

Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com>
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
ZwwWayne added a commit that referenced this pull request Nov 25, 2022
…9292)

* [Fix]: fix wrong padding value in cached MixUp (#9259)

* [Fix] Fix resume arg conflict. (#9287)

* [Fix] Fix `pixel_decoder_type` discrimination in MaskFormer Head. (#9176)

* [Fix] Fix pixel_decoder_type assertion in MaskFormer

* use isinstance assertion

* fix

* fix faq

* Apply suggestions from code review

Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com>

* fix format

* fix format

* fix faq.md

* Update docs/en/notes/faq.md

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>

* 1123

* Update faq.md

* fix format

Co-authored-by: plutoyuxie <34409171+plutoyuxie@users.noreply.github.com>
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
Co-authored-by: Haian Huang(深度眸) <1286304229@qq.com>
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants