Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add KeypointEndPointError #92

Merged
merged 7 commits into from
Feb 26, 2023
Merged

Conversation

LareinaM
Copy link
Contributor

@LareinaM LareinaM commented Feb 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add KeypointEndPointError metric.

Modification

  1. Add mmeval/metrics/keypoint_epe.py
  2. Modify metric doc and __init__.py
  3. Add unit test tests/test_metrics/test_keypoint_epe.py

Related PR on MMPose

open-mmlab/mmpose#1996
Update EPE to use MMEval

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint failed. Generally good! ^_^

mmeval/metrics/keypoint_epe.py Outdated Show resolved Hide resolved
mmeval/metrics/keypoint_epe.py Show resolved Hide resolved
tests/test_metrics/test_keypoint_epe.py Outdated Show resolved Hide resolved
@LareinaM
Copy link
Contributor Author

The lint failed. Generally good! ^_^

I looked into the lint and found it failed in the mdformat phase. Seems not very closely related to this PR (because I have checked that the changed files pass this hook)?

@C1rN09
Copy link
Collaborator

C1rN09 commented Feb 16, 2023

The lint failed. Generally good! ^_^

I looked into the lint and found it failed in the mdformat phase. Seems not very closely related to this PR (because I have checked that the changed files pass this hook)?

I checked with pre-commit run --all-files and it actually failed linting. You can have a try

@zhouzaida zhouzaida merged commit a4d01f0 into open-mmlab:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants