Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Update EPE to use MMEval #1996

Closed
wants to merge 1 commit into from

Conversation

LareinaM
Copy link
Collaborator

Motivation

Support MMEval's KeypointEndPointError metric in MMPose-1.x.

Related PR: open-mmlab/mmeval#92

Comparison with Default Implementation

Test command:

python tools/test.py configs/body_2d_keypoint/topdown_heatmap/mpii/td-hm_hrnet-w32_8xb64-210e_mpii-256x256.py https://download.openmmlab.com/mmpose/top_down/hrnet/hrnet_w32_mpii_256x256-6c4f923f_20200812.pth

Performance on dev-1.x branch:
image

Performance with this modifications:
image

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@LareinaM LareinaM changed the title Update EPE to use MMEval [WIP] Update EPE to use MMEval Feb 22, 2023
@ly015 ly015 marked this pull request as draft February 24, 2023 03:27
@LareinaM LareinaM changed the title [WIP] Update EPE to use MMEval [Draft] Update EPE to use MMEval Mar 14, 2023
@LareinaM LareinaM closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants