-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support the training of QDTrack algorithm in MOT #433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 72.51% 73.12% +0.61%
==========================================
Files 121 125 +4
Lines 7054 7218 +164
Branches 1332 1364 +32
==========================================
+ Hits 5115 5278 +163
+ Misses 1538 1519 -19
- Partials 401 421 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miss all docstrings
mmtrack/models/mot/qdtrack.py
Outdated
] | ||
return dict(det_bboxes=det_bboxes, track_bboxes=track_bboxes) | ||
|
||
def show_result(self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the show_result
in BaseMultiObjectTracker
mmtrack/models/mot/qdtrack.py
Outdated
|
||
return losses | ||
|
||
def simple_test(self, img, img_metas, rescale=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete the function in the PR, since the tracker is not in the PR
"""bool: whether the track head contains a `embed_head`""" | ||
return hasattr(self, 'embed_head') and self.embed_head is not None | ||
|
||
def init_weights(self, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use init_cfg
to init the weights of modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should have been careful about the docstring.
@@ -0,0 +1,100 @@ | |||
_base_ = './qdtrack_faster_rcnn_r50_fpn.py' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three configs still need to be refactored.
Please discuss it with me.
No description provided.