Add support for MPI-3.1 MPI_Aint functions #629

hjelmn · 2015-06-08T22:11:09Z

This commit adds support for MPI_Aint_add and MPI_Aint_diff. These
functions are implemented as macros in C (explicitly allowed by
MPI-3.1). The fortran implementations are a similar mess to the
MPI_Wtime implementations.

Signed-off-by: Nathan Hjelm hjelmn@lanl.gov

hjelmn · 2015-06-08T22:11:34Z

@jsquyres I have no idea if the fortran bindings are complete/correct. Can you take a look?

hjelmn · 2015-06-08T22:12:57Z

Jeff, can you also take a look at the man pages. Most of the text is directly copied from MPI-3.1.

lanl-ompi · 2015-06-08T22:24:30Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/114/

Build Log
last 20 lines

[...truncated 7372 lines...]
ompi/mpi/fortran/use-mpi-ignore-tkr/mpi-ignore-tkr-interfaces.h:203.33:
    Included at mpi-ignore-tkr.F90:44:

  integer(kind=MPI_ADDRESS_KIND :: addr1
                                 1
Error: Missing right parenthesis at (1)
ompi/mpi/fortran/use-mpi-ignore-tkr/mpi-ignore-tkr-interfaces.h:204.33:
    Included at mpi-ignore-tkr.F90:44:

  integer(kind=MPI_ADDRESS_KIND :: addr2
                                 1
Error: Missing right parenthesis at (1)
make[2]: *** [mpi-ignore-tkr.lo] Error 1
make[2]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi/mpi/fortran/use-mpi-ignore-tkr'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi'
make: *** [all-recursive] Error 1
Build step 'Execute shell' marked build as failure
Setting status of dbe0ce555c01a83ff686163e2d551f8e5d6aa23e to FAILURE with url http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/114/ and message: Build finished.

Test FAILed.

lanl-ompi · 2015-06-08T22:26:06Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_distcheck/25/
Test PASSed.

hjelmn · 2015-06-08T22:28:15Z

Once these are ready I plan to file a PR for 1.10 since the changes should go in cleanly. No reason not to have these MPI-3.1 functions there.

lanl-ompi · 2015-06-08T22:37:37Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/115/

Build Log
last 20 lines

[...truncated 7371 lines...]
ompi/mpi/fortran/use-mpi-ignore-tkr/mpi-ignore-tkr-interfaces.h:203.33:
    Included at mpi-ignore-tkr.F90:44:

  integer(kind=MPI_ADDRESS_KIND :: addr1
                                 1
Error: Missing right parenthesis at (1)
ompi/mpi/fortran/use-mpi-ignore-tkr/mpi-ignore-tkr-interfaces.h:204.33:
    Included at mpi-ignore-tkr.F90:44:

  integer(kind=MPI_ADDRESS_KIND :: addr2
                                 1
Error: Missing right parenthesis at (1)
make[2]: *** [mpi-ignore-tkr.lo] Error 1
make[2]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi/mpi/fortran/use-mpi-ignore-tkr'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi'
make: *** [all-recursive] Error 1
Build step 'Execute shell' marked build as failure
Setting status of 810bf3e532a4b3380d969c2506eb875880c956ab to FAILURE with url http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/115/ and message: Build finished.

Test FAILed.

mellanox-github · 2015-06-08T22:39:14Z

Coverity found 815 errors for all
Coverity found 5 errors for oshmem
Coverity found 2 errors for fca
Coverity report at http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//605/Coverity_Report

Sent from GH.

lanl-ompi · 2015-06-08T22:41:37Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_distcheck/26/
Test PASSed.

mellanox-github · 2015-06-08T22:43:10Z

Coverity found 815 errors for all
Coverity found 5 errors for oshmem
Coverity found 2 errors for fca
Coverity report at http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//606/Coverity_Report

Sent from GH.

lanl-ompi · 2015-06-08T22:50:54Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/116/

Build Log
last 20 lines

[...truncated 7591 lines...]
Error: Expecting 'END INTERFACE pmpi_aint_diff' at (1)
pmpi-f08-interfaces.F90:2511.38:

interface  PMPI_Comm_create_errhandler
                                      1
Error: Unexpected INTERFACE statement in INTERFACE block at (1)
pmpi-f08-interfaces.F90:2520.42:

end interface  PMPI_Comm_create_errhandler
                                          1
Error: Expecting 'END INTERFACE pmpi_aint_diff' at (1)
Fatal Error: Error count reached limit of 25.
make[2]: *** [pmpi-f08-interfaces.lo] Error 1
make[2]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi/mpi/fortran/use-mpi-f08'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi'
make: *** [all-recursive] Error 1
Build step 'Execute shell' marked build as failure
Setting status of 2b67b1410878c989e2b502d3346e84a28453e06a to FAILURE with url http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/116/ and message: Build finished.

Test FAILed.

mellanox-github · 2015-06-08T22:53:10Z

Coverity found 815 errors for all
Coverity found 5 errors for oshmem
Coverity found 2 errors for fca
Coverity report at http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//607/Coverity_Report

Sent from GH.

mellanox-github · 2015-06-08T22:54:23Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/605/

lanl-ompi · 2015-06-08T22:56:52Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_distcheck/27/
Test PASSed.

mellanox-github · 2015-06-08T22:58:21Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/606/

lanl-ompi · 2015-06-08T23:03:43Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/117/

Build Log
last 20 lines

[...truncated 7590 lines...]
Error: Expecting 'END INTERFACE pmpi_aint_diff' at (1)
pmpi-f08-interfaces.F90:2511.38:

interface  PMPI_Comm_create_errhandler
                                      1
Error: Unexpected INTERFACE statement in INTERFACE block at (1)
pmpi-f08-interfaces.F90:2520.42:

end interface  PMPI_Comm_create_errhandler
                                          1
Error: Expecting 'END INTERFACE pmpi_aint_diff' at (1)
Fatal Error: Error count reached limit of 25.
make[2]: *** [pmpi-f08-interfaces.lo] Error 1
make[2]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi/mpi/fortran/use-mpi-f08'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi'
make: *** [all-recursive] Error 1
Build step 'Execute shell' marked build as failure
Setting status of c4a310d84179a9e8fd408f25bf34d4b85d9f2760 to FAILURE with url http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/117/ and message: Build finished.

Test FAILed.

mellanox-github · 2015-06-08T23:08:27Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/607/

hjelmn · 2015-06-08T23:08:29Z

More bugs. Will update tomorrow.

lanl-ompi · 2015-06-08T23:12:01Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_distcheck/28/
Test PASSed.

mellanox-github · 2015-06-08T23:14:55Z

Coverity found 815 errors for all
Coverity found 5 errors for oshmem
Coverity found 2 errors for fca
Coverity report at http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//608/Coverity_Report

Sent from GH.

lanl-ompi · 2015-06-08T23:16:41Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/118/

Build Log
last 20 lines

[...truncated 7591 lines...]
Error: Expecting 'END INTERFACE pmpi_aint_diff' at (1)
pmpi-f08-interfaces.F90:2511.38:

interface  PMPI_Comm_create_errhandler
                                      1
Error: Unexpected INTERFACE statement in INTERFACE block at (1)
pmpi-f08-interfaces.F90:2520.42:

end interface  PMPI_Comm_create_errhandler
                                          1
Error: Expecting 'END INTERFACE pmpi_aint_diff' at (1)
Fatal Error: Error count reached limit of 25.
make[2]: *** [pmpi-f08-interfaces.lo] Error 1
make[2]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi/mpi/fortran/use-mpi-f08'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/global/u2/h/hpp/jenkins_edison/workspace/ompi_master_pr_cle5.2up02/ompi'
make: *** [all-recursive] Error 1
Build step 'Execute shell' marked build as failure
Setting status of e88969f554880948285203603b7490118ec8049a to FAILURE with url http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/118/ and message: Build finished.

Test FAILed.

mellanox-github · 2015-06-08T23:18:01Z

Coverity found 815 errors for all
Coverity found 5 errors for oshmem
Coverity found 2 errors for fca
Coverity report at http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//609/Coverity_Report

Sent from GH.

lanl-ompi · 2015-06-08T23:27:02Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_distcheck/29/
Test PASSed.

mellanox-github · 2015-06-08T23:29:24Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/608/

mellanox-github · 2015-06-08T23:32:34Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/609/

This commit adds support for MPI_Aint_add and MPI_Aint_diff. These functions are implemented as macros in C (explicitly allowed by MPI-3.1). The fortran implementations are a similar mess to the MPI_Wtime implementations. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>

lanl-ompi · 2015-06-09T15:47:33Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_distcheck/31/
Test PASSed.

lanl-ompi · 2015-06-09T15:48:02Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins.open-mpi.org/job/ompi_master_pr_cle5.2up02/120/
Test PASSed.

mellanox-github · 2015-06-09T15:56:29Z

Coverity found 814 errors for all
Coverity found 5 errors for oshmem
Coverity found 2 errors for fca
Coverity report at http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//611/Coverity_Report

Sent from GH.

mellanox-github · 2015-06-09T16:11:26Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/611/

jsquyres · 2015-06-24T14:16:42Z

ompi/mpi/man/man3/MPI_Aint_add.3in

+the addresses had called (char *) \fIaddr1\fP - (char *) \fIaddr2\fP
+on the addresses initially passed to \fBMPI_Get_address\fP.
+
+.SH FORTRAN 77 NOTES


Remove this section on F77 notes (and the "See FORTRAN 77 nodes" on line 22).

Ditto for the other man page.

jsquyres · 2015-06-24T15:35:35Z

@hjelmn Pull request filed against your repo to fix the F08 bindings (although I didn't fix the man pages).

(cherry picked from commit 8f252e65b02bfe20cacee0ece8c835246eea3bd9)

mpi-f08: corrections to new MPI_Aint_* subroutines

Signed-off-by: Nathan Hjelm <hjelmn@me.com>

jsquyres · 2015-06-24T17:52:36Z

👍

Add support for MPI-3.1 MPI_Aint functions

mellanox-github · 2015-06-24T17:53:43Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/653/

Build Log
last 50 lines

GitHub pull request #629 of commit 6dd9658d73c792662a18681eecd87466c45863bf, no merge conflicts.
Setting status of 6dd9658d73c792662a18681eecd87466c45863bf to PENDING with url http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr/653/ and message: 'Build started, sha1 is merged'
Using conext: Mellanox
[EnvInject] - Loading node environment variables.
Building on master in workspace /var/lib/jenkins/jobs/gh-ompi-master-pr/workspace-2
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/open-mpi/ompi
 > /usr/bin/git init /var/lib/jenkins/jobs/gh-ompi-master-pr/workspace-2 # timeout=60
Fetching upstream changes from https://github.com/open-mpi/ompi
 > /usr/bin/git --version # timeout=60
using .gitcredentials to set credentials
 > /usr/bin/git config --local credential.helper store --file=/tmp/git5556004118502115884.credentials # timeout=60
 > /usr/bin/git -c core.askpass=true fetch --tags --progress https://github.com/open-mpi/ompi +refs/heads/*:refs/remotes/origin/* # timeout=60
 > /usr/bin/git config --local --remove-section credential # timeout=60
 > /usr/bin/git config remote.origin.url https://github.com/open-mpi/ompi # timeout=60
 > /usr/bin/git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=60
 > /usr/bin/git config remote.origin.url https://github.com/open-mpi/ompi # timeout=60
Pruning obsolete local branches
Fetching upstream changes from https://github.com/open-mpi/ompi
using .gitcredentials to set credentials
 > /usr/bin/git config --local credential.helper store --file=/tmp/git1238703052703266541.credentials # timeout=60
 > /usr/bin/git -c core.askpass=true fetch --tags --progress https://github.com/open-mpi/ompi +refs/pull/*:refs/remotes/origin/pr/* --prune # timeout=60
 > /usr/bin/git config --local --remove-section credential # timeout=60
 > /usr/bin/git rev-parse refs/remotes/origin/pr/629/merge^{commit} # timeout=60
 > /usr/bin/git rev-parse refs/remotes/origin/origin/pr/629/merge^{commit} # timeout=60
 > /usr/bin/git rev-parse origin/pr/629/merge^{commit} # timeout=60
ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.
[htmlpublisher] Archiving HTML reports...
[htmlpublisher] Archiving at BUILD level /var/lib/jenkins/jobs/gh-ompi-master-pr/workspace-2/cov_build to /var/lib/jenkins/jobs/gh-ompi-master-pr/builds/653/htmlreports/Coverity_Report
Setting commit status on GitHub for https://github.com/open-mpi/ompi/commit/65d5dce990d757e12f332cd7d43f47b94cc38593
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
Setting status of 6dd9658d73c792662a18681eecd87466c45863bf to FAILURE with url http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr/653/ and message: 'Build finished.'
Using conext: Mellanox

lanl-ompi · 2015-06-24T18:08:02Z

Test FAILed.

mellanox-github · 2015-06-24T18:22:19Z

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/652/

op: allow user operations in ompi_3buff_op_reduce

hjelmn force-pushed the aint_math branch from dbe0ce5 to 810bf3e Compare June 8, 2015 22:20

hjelmn force-pushed the aint_math branch from 810bf3e to 2b67b14 Compare June 8, 2015 22:27

hjelmn force-pushed the aint_math branch from 2b67b14 to c4a310d Compare June 8, 2015 22:46

hjelmn force-pushed the aint_math branch from c4a310d to e88969f Compare June 8, 2015 22:54

hjelmn force-pushed the aint_math branch from e88969f to 062de45 Compare June 9, 2015 15:31

jsquyres reviewed Jun 24, 2015
View reviewed changes

jsquyres and others added 3 commits June 24, 2015 10:42

mpi-f08: corrections to new MPI_Aint_* subroutines

258d1aa

(cherry picked from commit 8f252e65b02bfe20cacee0ece8c835246eea3bd9)

Merge pull request #3 from jsquyres/hjelmn-aint_math

1a1492a

mpi-f08: corrections to new MPI_Aint_* subroutines

man: remove F77 notes from MPI_Aint_add/MPI_Aint_diff man pages

6dd9658

Signed-off-by: Nathan Hjelm <hjelmn@me.com>

hjelmn added a commit that referenced this pull request Jun 24, 2015

Merge pull request #629 from hjelmn/aint_math

458cd9d

Add support for MPI-3.1 MPI_Aint functions

hjelmn merged commit 458cd9d into open-mpi:master Jun 24, 2015

jsquyres deleted the aint_math branch June 24, 2015 17:52

hppritcha added this to the Open MPI v2.0.0 milestone Jun 24, 2015

hjelmn mentioned this pull request Oct 14, 2015

v2.x MPI_Aint functions open-mpi/ompi-release#667

Merged

jsquyres added a commit to jsquyres/ompi that referenced this pull request Sep 19, 2016

Merge pull request open-mpi#629 from hjelmn/v1.10_libnbc_fixes

9a50afe

op: allow user operations in ompi_3buff_op_reduce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for MPI-3.1 MPI_Aint functions #629

Add support for MPI-3.1 MPI_Aint functions #629

hjelmn commented Jun 8, 2015

hjelmn commented Jun 8, 2015

hjelmn commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

hjelmn commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

hjelmn commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 9, 2015

lanl-ompi commented Jun 9, 2015

mellanox-github commented Jun 9, 2015

mellanox-github commented Jun 9, 2015

jsquyres Jun 24, 2015

jsquyres commented Jun 24, 2015

jsquyres commented Jun 24, 2015

mellanox-github commented Jun 24, 2015

lanl-ompi commented Jun 24, 2015

mellanox-github commented Jun 24, 2015

Add support for MPI-3.1 MPI_Aint functions #629

Add support for MPI-3.1 MPI_Aint functions #629

Conversation

hjelmn commented Jun 8, 2015

hjelmn commented Jun 8, 2015

hjelmn commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

hjelmn commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

hjelmn commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

mellanox-github commented Jun 8, 2015

lanl-ompi commented Jun 9, 2015

lanl-ompi commented Jun 9, 2015

mellanox-github commented Jun 9, 2015

mellanox-github commented Jun 9, 2015

jsquyres Jun 24, 2015

Choose a reason for hiding this comment

jsquyres commented Jun 24, 2015

jsquyres commented Jun 24, 2015

mellanox-github commented Jun 24, 2015

lanl-ompi commented Jun 24, 2015

mellanox-github commented Jun 24, 2015