Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric names mismatch: *_count in document, *_count_total in actual behavior #3349

Closed
ordovicia opened this issue Apr 9, 2024 · 1 comment · Fixed by #3353
Closed

Metric names mismatch: *_count in document, *_count_total in actual behavior #3349

ordovicia opened this issue Apr 9, 2024 · 1 comment · Fixed by #3353
Labels
bug Something isn't working

Comments

@ordovicia
Copy link

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

The document states that Gatekeeper provides gatekeeper_constraint_template_ingestion_count and other *_count metrics.
https://open-policy-agent.github.io/gatekeeper/website/docs/metrics/#metrics

But Gatekeeper actually serves gatekeeper_constraint_template_ingestion_count_total and other *_count_total metrics.

$ curl -s localhost:8888/metrics | rg "# HELP.+_count"
# HELP gatekeeper_constraint_template_ingestion_count_total Total number of constraint template ingestion actions
# HELP gatekeeper_mutation_request_count_total The number of requests that are routed to mutation webhook
# HELP gatekeeper_mutator_conflicting_count The current number of conflicting Mutator objects
# HELP gatekeeper_mutator_ingestion_count_total Total number of Mutator ingestion actions
# HELP gatekeeper_validation_request_count_total The number of requests that are routed to validation webhook

What did you expect to happen:

The documentation and actual behavior match

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

I think modifying metric names will make a big impact on users.
So updating the documentation will be a right resolution.

Environment:

  • Gatekeeper version: 3.15.1
  • Kubernetes version: (use kubectl version): 1.29.3
@ordovicia ordovicia added the bug Something isn't working label Apr 9, 2024
@ritazh
Copy link
Member

ritazh commented Apr 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants