-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger downstream CI ? #1499
Comments
@baentsch I'm taking a look at triggering the liboqs-python CI via the GitHub API, which involves a bit of tinkering with the CI for both that repo and liboqs. Are there any jobs (e.g., release/deploy/etc) that I should be careful not to trigger by mistake? |
My approach was to develop this in separate repos before deploying it: See https://github.com/baentsch/ghtestsuper/blob/main/.github/workflows/test.yml for trigger and https://github.com/baentsch/ghtestsub/blob/main/.github/workflows/test.yml for receiver. That way no-one got annoyed. My proposal would be to add the receiver code first and when that's merged, start to trigger, first by command line, then by CI. |
Oh, and welcome on board, @SWilson4 ! |
Just checked again all subprojects: In |
I have a PR open for the liboqs-python side here: open-quantum-safe/liboqs-python#65 Quick note: it seems that "success" in the liboqs pipeline doesn't mean that the liboqs-python pipeline completed with no errors but rather that it was started successfully. To confirm that the downstream pipeline completed successfully, you have to check manually. This seems to be compatible with the current behaviour of the other downstream projects, so I assume it's OK? |
Thanks! Approved.
Yes: If any of the triggered downstream fails, they tell us by email and status report at https://openquantumsafe.org/dashboard.html |
open-quantum-safe/liboqs-python@f52b265 removed CCI support in that subproject. #1498 fixes the consequent CCI failure in
liboqs
.This triggered the question for me whether we still want to trigger downstream CI (and/or for which subprojects) -- and (if/where) to consequently add/change the CI trigger logic (e.g., trigger downstream
github
actions instead of CCI)?From the perspective of testing integrations it would be goodness, but it puts responsibilities/can trigger work in downstream projects.
Somewhat related: open-quantum-safe/oqs-provider#182 adds a CCI trigger from oqs-provider to oqs-demos as (various) oqs-demos integrate oqs-provider. A similar trigger exists from oqs-openssl111 to oqs-demos. This leads to an inefficient repeated execution of oqs-demos CCI if
liboqs
changes trigger downstream CCI to bothoqs-openssl111
andoqs-provider
. Can this be improved/are both necessary?The text was updated successfully, but these errors were encountered: