Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger downstream CI ? #1499

Closed
baentsch opened this issue Jun 14, 2023 · 7 comments · Fixed by #1507
Closed

Trigger downstream CI ? #1499

baentsch opened this issue Jun 14, 2023 · 7 comments · Fixed by #1507
Milestone

Comments

@baentsch
Copy link
Member

open-quantum-safe/liboqs-python@f52b265 removed CCI support in that subproject. #1498 fixes the consequent CCI failure in liboqs.

This triggered the question for me whether we still want to trigger downstream CI (and/or for which subprojects) -- and (if/where) to consequently add/change the CI trigger logic (e.g., trigger downstream github actions instead of CCI)?

From the perspective of testing integrations it would be goodness, but it puts responsibilities/can trigger work in downstream projects.

Somewhat related: open-quantum-safe/oqs-provider#182 adds a CCI trigger from oqs-provider to oqs-demos as (various) oqs-demos integrate oqs-provider. A similar trigger exists from oqs-openssl111 to oqs-demos. This leads to an inefficient repeated execution of oqs-demos CCI if liboqs changes trigger downstream CCI to both oqs-openssl111 and oqs-provider. Can this be improved/are both necessary?

@baentsch
Copy link
Member Author

#1498 (comment)

@baentsch baentsch added this to the 0.9.0 milestone Jun 28, 2023
@SWilson4
Copy link
Member

SWilson4 commented Jul 10, 2023

@baentsch I'm taking a look at triggering the liboqs-python CI via the GitHub API, which involves a bit of tinkering with the CI for both that repo and liboqs. Are there any jobs (e.g., release/deploy/etc) that I should be careful not to trigger by mistake?

@baentsch
Copy link
Member Author

My approach was to develop this in separate repos before deploying it: See https://github.com/baentsch/ghtestsuper/blob/main/.github/workflows/test.yml for trigger and https://github.com/baentsch/ghtestsub/blob/main/.github/workflows/test.yml for receiver. That way no-one got annoyed. My proposal would be to add the receiver code first and when that's merged, start to trigger, first by command line, then by CI.

@baentsch
Copy link
Member Author

Oh, and welcome on board, @SWilson4 !

@baentsch
Copy link
Member Author

that I should be careful not to trigger by mistake

Just checked again all subprojects: In github there's no CI task yet that triggers persistent changes -- apart from what's coming online when open-quantum-safe/oqs-demos#214 gets merged: That'll be the first github CI that is both "triggerable" and creating persistent artifacts. But I don't see a reason why you shouldn't be "trigger happy" even with that one :-)

@SWilson4
Copy link
Member

I have a PR open for the liboqs-python side here: open-quantum-safe/liboqs-python#65

Quick note: it seems that "success" in the liboqs pipeline doesn't mean that the liboqs-python pipeline completed with no errors but rather that it was started successfully. To confirm that the downstream pipeline completed successfully, you have to check manually. This seems to be compatible with the current behaviour of the other downstream projects, so I assume it's OK?

@baentsch
Copy link
Member Author

I have a PR open for the liboqs-python side here: open-quantum-safe/liboqs-python#65

Thanks! Approved.

so I assume it's OK?

Yes: If any of the triggered downstream fails, they tell us by email and status report at https://openquantumsafe.org/dashboard.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants