Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_args not correctly functioning #1703

Closed
baentsch opened this issue Feb 23, 2024 · 0 comments · Fixed by #1716
Closed

filter_args not correctly functioning #1703

baentsch opened this issue Feb 23, 2024 · 0 comments · Fixed by #1716
Milestone

Comments

@baentsch
Copy link
Member

baentsch commented Feb 23, 2024

there seems another issue with filter_algs which appears to set everything to OFF except those explicitly provided.
For example, using the STD config I get

#define OQS_ENABLE_SIG_FALCON 1
#define OQS_ENABLE_SIG_falcon_512 1
/* #undef OQS_ENABLE_SIG_falcon_512_avx2 */
/* #undef OQS_ENABLE_SIG_falcon_512_aarch64 */
...

But I'd expect the aarch64-optimized version to be enabled on my laptop, which is the case with the cmake default config.

Originally posted by @bhess in #1702 (comment)

(apologies to @bhess for incorrectly assigning this instead of #1704).

@baentsch baentsch added this to the 0.10.0 milestone Feb 23, 2024
@bhess bhess mentioned this issue Mar 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants