-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OQS_MINIMAL_BUILD option and redefine CI workflow #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already stated, I like the option. But I'm missing a (CI) test run/config with this option on in this PR.
5675c47
to
72db3f6
Compare
72db3f6
to
6d59b0b
Compare
b15d648
to
8e5c107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the CI changes/platform removals -- but still don't understand what/who provides testapproval
/unlocks the next stage(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or are the arm tests triggered by an approval like this?
Anyone on the team can click through to https://app.circleci.com/pipelines/github/open-quantum-safe, click the testapproval job marked in purple, then click "approve". That will run the remaining arm jobs and then you should be able to merge the PR. |
Just to check I finally got it: The idea here is that anyone can do a quick PR CI, but only after a team member approved the long-running (say, arm) tests (and/or request naming the branch "...audit..." if such testing seems in order), CI + PR can conclude (?) One more click for team members doing PRs, but a much faster sanity check. OK for me: My approval stands. |
Exactly. |
This adds an option to build only the default KEM and Signature scheme. For example, with this patch, if you want to build liboqs with only the Kyber512 and Dilithium2 algorithms you can use:
This will build the exact match for the default kem and sig and also any "_aesni" or "_avx2" implementations that are supported by the platform.
Opening this PR, at @baentsch's recommendation, for discussion about whether this is a useful feature / what else we would like it to do.
Edit: Tacking on proposed CI workflow from #907 (comment)