-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing CMake target_include_directory for Kyber768 #899
Comments
Bug confirmed. Probably something for @bhess? Side note:
This is a really nice new build switch: hope you intend to do a PR for this: Fast(er) build, (comparatively) small lib, (nearly) fully functioning. Nearly: |
Closed
bhess
added a commit
to bhess/liboqs
that referenced
this issue
Feb 9, 2021
* Kyber768 ref dependencies (open-quantum-safe#899)
bhess
added a commit
to bhess/liboqs
that referenced
this issue
Feb 10, 2021
bhess
added a commit
to bhess/liboqs
that referenced
this issue
Feb 10, 2021
baentsch
pushed a commit
that referenced
this issue
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upstream Kyber768_META.yml is missing a "common_dep: common_ref" line, which results in OQS_ENABLE_KEM_kyber_768 being omitted from this if statement:
liboqs/src/kem/kyber/CMakeLists.txt
Lines 8 to 12 in 1256e3b
If you try to build liboqs with only Kyber768 (and none of the other Kyber parameter sets), the build will fail with undefined references.
This can be reproduced using my feat.minimal-build branch (jschanck/liboqs@4feed617).
The text was updated successfully, but these errors were encountered: