Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve qsc encoder integration #130

Closed
baentsch opened this issue Mar 25, 2023 · 1 comment · Fixed by #131
Closed

Improve qsc encoder integration #130

baentsch opened this issue Mar 25, 2023 · 1 comment · Fixed by #131

Comments

@baentsch
Copy link
Member

Build time for oqs-provider significantly deteriorated when qsc-encoder integration was done. A glance at disk usage shows the problem vividly: The src of qsc-encoder is more than 2x as large as all of OpenSSL, 3x the size of a fully built liboqs and thus roughly 60% of a complete oqs-provider build (incl. opensslv3 binaries and libraries):

grafik

--> Is it really necessary to add KATs for all algorithms (again)? That alone seems to be 255MBytes. Then there's PPTX files and huge .git index files: The latter are 38x larger in qsc-encoder than in all of oqs-provider (3.5MB vs 138MB).

@bhess: Do you agree that this is not OK and have time to remedy this?

@bhess
Copy link
Member

bhess commented Mar 25, 2023

Yes the repo was quite large due to the KAT and unrelated files. I now created a separate smaller repository containing only the library. See PR #131.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants