Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on internal OpenSSL test harness #137

Closed
baentsch opened this issue Apr 1, 2023 · 2 comments · Fixed by #153
Closed

Remove dependency on internal OpenSSL test harness #137

baentsch opened this issue Apr 1, 2023 · 2 comments · Fixed by #153
Labels
help wanted Extra attention is needed

Comments

@baentsch
Copy link
Member

baentsch commented Apr 1, 2023

Some tests depend on ssltestlib, an OpenSSL internal test library. This dependency causes issues when testing in a setup without this code present (non-master source, binary-only).

This issue is to suggest removing this dependency and to develop independent tests providing similar functionality.

@baentsch baentsch added the help wanted Extra attention is needed label Apr 1, 2023
@mouse07410
Copy link
Contributor

Perhaps, just copying test/helpers/ssltestlib.c to this repo with the appropriate patch...? it does seem to include some internal headers though...

@baentsch
Copy link
Member Author

baentsch commented Apr 2, 2023

Yup -- it has many (internal) dependencies -- that further change between versions. Not in option in my eyes. Testing using just the official, external OpenSSL APIs surely is possible -- just "a bit of work"... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants