Add back missing ament index path exporting in CMakeLists #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Bainian <chenbn@artc.a-star.edu.sg>
|
@mxgrey it seems like PR https://github.com/open-rmf/rmf_battery/pull/23/files removed these changes that were previously merged in. May I check if that was intentional? |
|
Definitely not intentional. I don't know how that would've happened. |
Yadunund
approved these changes
Mar 13, 2023
|
Gotcha, I'll merge this in then. |
Yadunund
added a commit
that referenced
this pull request
Apr 14, 2023
* [CI] Reusable ci (#28) Modified build.yaml to make use of reusable workflow. Signed-off-by: Esteban Martinena <orensbruli@gmail.com> * Add buildtool_depend on cmake (#31) Even though this is considered a CMake package, it should declare a dependency on the cmake build tool. Signed-off-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Scott K Logan <logans@cottsay.net> * Add back missing ament index path exporting in CMakeLists (#33) Signed-off-by: Chen Bainian <chenbn@artc.a-star.edu.sg> --------- Signed-off-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Chen Bainian <chenbn@artc.a-star.edu.sg> Co-authored-by: Esteban Martinena Guerrero <orensbruli@gmail.com> Co-authored-by: Scott K Logan <logans@cottsay.net> Co-authored-by: Chen Bainian <brian97cbn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #32
Adding back the fixes submitted in #22.