Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yaml #16

Merged
merged 2 commits into from Mar 29, 2021
Merged

Update build.yaml #16

merged 2 commits into from Mar 29, 2021

Conversation

cnboonhan
Copy link
Contributor

Bug fix

fix build for rmf_demo_panel due to change of path of rmf_demos

youliangtan
youliangtan previously approved these changes Mar 29, 2021
fix build for rmf_demo_panel

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
youliangtan
youliangtan previously approved these changes Mar 29, 2021
Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youliangtan youliangtan merged commit 6a94ea4 into main Mar 29, 2021
@youliangtan youliangtan deleted the cnboonhan-patch-1 branch March 29, 2021 02:39
cnboonhan added a commit that referenced this pull request Mar 29, 2021
* Update build.yaml

fix build for rmf_demo_panel

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* further README update to fix panel npm build

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
cnboonhan added a commit that referenced this pull request Mar 29, 2021
* Update build.yaml

fix build for rmf_demo_panel

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* further README update to fix panel npm build

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
youliangtan pushed a commit that referenced this pull request Mar 29, 2021
* account for refactor from building_gazebo_plugins to rmf_building_sim… (#15)

* account for refactor from building_gazebo_plugins to rmf_building_sim_gazebo_plugins

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* remove duplicate rmf_demos folders

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* rename dependency following recent refactor

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* account for renaming to rmf_building_map_tools

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* fix build.yaml to check out the current repo before build tests

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* Update build.yaml (#16)

* Update build.yaml

fix build for rmf_demo_panel

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>

* further README update to fix panel npm build

Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants