account for refactor from building_gazebo_plugins to rmf_building_sim… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_gazebo_plugins Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
gbiggs
approved these changes
Mar 27, 2021
cnboonhan
added a commit
that referenced
this pull request
Mar 29, 2021
#15) * account for refactor from building_gazebo_plugins to rmf_building_sim_gazebo_plugins Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * remove duplicate rmf_demos folders Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
cnboonhan
added a commit
that referenced
this pull request
Mar 29, 2021
#15) * account for refactor from building_gazebo_plugins to rmf_building_sim_gazebo_plugins Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * remove duplicate rmf_demos folders Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
youliangtan
pushed a commit
that referenced
this pull request
Mar 29, 2021
* account for refactor from building_gazebo_plugins to rmf_building_sim… (#15) * account for refactor from building_gazebo_plugins to rmf_building_sim_gazebo_plugins Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * remove duplicate rmf_demos folders Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * rename dependency following recent refactor Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * account for renaming to rmf_building_map_tools Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * fix build.yaml to check out the current repo before build tests Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * Update build.yaml (#16) * Update build.yaml fix build for rmf_demo_panel Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * further README update to fix panel npm build Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactoring to account for changes from this refactoring. Also changed the build script to remove a duplicate rmf_demo workspace from this change.
Will depend on refactors from open-rmf/rmf_visualization#5 and open-rmf/rmf_simulation#3 for clean successful build.
Signed-off-by: Boon Han charayaphan.nakorn.boon.han@gmail.com