rename dependency following recent refactor #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnboonhan
force-pushed
the
refactor/rmf_building_map_tools
branch
from
1aa75db
to
fc97ad2
Compare
cnboonhan
force-pushed
the
refactor/rmf_building_map_tools
branch
2 times, most recently
from
a12f868
to
8472c94
Compare
youliangtan
requested changes
Mar 29, 2021
There was a problem hiding this comment.
One thing that i missed out. This CI build will fail because of the removal of
- name: checkout
uses: actions/checkout@v2
with:
path: rmf_demos_ws/src/rmf/rmf_demosfrom build.yaml, in #15
This is important so that we are using the current changes in this repo, instead of the rmf.repos.
youliangtan
previously approved these changes
Mar 29, 2021
cnboonhan
force-pushed
the
refactor/rmf_building_map_tools
branch
from
f7e2504
to
31dad82
Compare
cnboonhan
force-pushed
the
refactor/rmf_building_map_tools
branch
from
31dad82
to
9a14ea5
Compare
#15) * account for refactor from building_gazebo_plugins to rmf_building_sim_gazebo_plugins Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * remove duplicate rmf_demos folders Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
* Update build.yaml fix build for rmf_demo_panel Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com> * further README update to fix panel npm build Signed-off-by: Boon Han <charayaphan.nakorn.boon.han@gmail.com>
cnboonhan
force-pushed
the
refactor/rmf_building_map_tools
branch
from
9a14ea5
to
556292f
Compare
youliangtan
approved these changes
Mar 29, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Rename dependency to follow refactoring: open-rmf/rmf_traffic_editor#308