Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All to be downloaded using http and stored in .gazebo/models #185

Merged
merged 1 commit into from Jul 5, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Jul 4, 2023

Bug fix

Fixed bug

Fixes open-rmf/rmf_traffic_editor#469
Requires open-rmf/rmf_traffic_editor#470.

  • Fixes the issue where rmf_demos_gz_classic model downloads repeatedly
  • Stop exporting models into ws/install/rmf_demos_maps, since we do not plan to release rmf_demos packages as binaries any more

Fix applied

Revert to using http download, as it retains the model:// tag instead of the full Fuel url, gazebosim/gz-fuel-tools#77 (comment).

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit f562ea4 into main Jul 5, 2023
3 checks passed
@aaronchongth aaronchongth deleted the fix/gz-classic-model-dl branch July 5, 2023 02:21
aaronchongth added a commit that referenced this pull request Jul 5, 2023
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit f562ea4)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Jul 5, 2023
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit f562ea4)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
This was referenced Jul 5, 2023
Yadunund pushed a commit that referenced this pull request Jul 10, 2023
…186)

(cherry picked from commit f562ea4)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Yadunund pushed a commit that referenced this pull request Jul 10, 2023
…187)

(cherry picked from commit f562ea4)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pit crew] Models are downloaded each time when running Gazebo classic simulations
2 participants