Fix/gz classic model dl #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…z-classic Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
… too Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
mxgrey
approved these changes
Jul 4, 2023
aaronchongth
added a commit
that referenced
this pull request
Jul 5, 2023
* Using http to download all models until we choose to stop supprting gz-classic Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Make changes to test map package to export models to ~/.gazebo/models too Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Check for missing models in .gazebo/models with non-lowercase names Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> (cherry picked from commit 6b647c0) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
added a commit
that referenced
this pull request
Jul 5, 2023
* Using http to download all models until we choose to stop supprting gz-classic Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Make changes to test map package to export models to ~/.gazebo/models too Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Check for missing models in .gazebo/models with non-lowercase names Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> (cherry picked from commit 6b647c0) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
This was referenced Jul 5, 2023
Merged
Merged
Yadunund
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Using http to download all models until we choose to stop supprting gz-classic * Make changes to test map package to export models to ~/.gazebo/models too * Check for missing models in .gazebo/models with non-lowercase names --------- (cherry picked from commit 6b647c0) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Yadunund
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Using http to download all models until we choose to stop supprting gz-classic * Make changes to test map package to export models to ~/.gazebo/models too * Check for missing models in .gazebo/models with non-lowercase names --------- (cherry picked from commit 6b647c0) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Fixes #469
Fix applied
Revert the use of http downloads, as it retains the
model://URI tags, instead of the full Fuel URI, gazebosim/gz-fuel-tools#77 (comment).