Quality declarations #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
gbiggs
pushed a commit
that referenced
this pull request
Mar 5, 2021
* Update API * Finalize rmf_mock_adapter_python (with tests!) * Add README for rmf_mock_adapter_python * Implement rmf_fleet_adapter bindings * Bind tests * Bind MockAdapter * Implement new graph interfaces * Implement node access for RobotCommandHandle * Cleanup dirs * Update fleet_adapter_python interfaces * Update mock_adapter_python interfaces * Allow overloaded overrides on the Python side * Fix pybind11 binding pointer and memory issues * Implement the appropriate rclcpp interfaces * Tentative preliminary test_delivery Python implementation The final dispenser can't get reached before memory explodes * Implement unit tests * Update Plan::Waypoint::time interface * Clarify CPPDeliveryMsg * Implement ros2 time_point conversion helpers * Implement working integration test * Refactor time to use system_clock * Clear up potentially confusing time interfaces * Implement parse_graph * Add repo README * Build rmf_fleet_adapter_python in release! * Update README * Update rmf_mock_adapter_python README * Update rmf_mock_adapter_python README * Update rmf_fleet_adapter_python README * Add clarifying note for dispenser classes in fleet test * Remove redundant comments * Fix style * Fix even more style issues * Fix assert bug * Clarify steady_clock::time_point cast and fix style * Remove rmf_mock_adapter_python * Add license and version * Remove VelocityConstraint * Update READMEs Co-authored-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
gbiggs
commented
Apr 27, 2021
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
mxgrey
approved these changes
May 4, 2021
luca-della-vedova
pushed a commit
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Michael X. Grey <grey@openrobotics.org> Co-authored-by: Michael X. Grey <grey@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds quality declaration documents and (where necessary) basic README files too all packages in
rmf_core_ros2.All source-code-containing packages are currently QL4.