Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to traffic dependency system #188

Merged
merged 28 commits into from
Mar 20, 2022
Merged

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Mar 18, 2022

This PR updates the fleet adapters to use the new traffic dependency system of RMF. Read more on the new system and its benefits here.

For the fleet adapters, the API remains exactly the same, with just these notes to account for:

  • The original TrafficLight API is now completely removed. Relative to the new dependency-based system, the old traffic light system was unreliable. Besides it was so difficult to use that I don't believe anyone was using it anyway. The EasyTrafficLight API remains exactly as-is, but should now behave much better since it has been reimplemented to use the new dependency system.
  • The "Full Control" API [1] [2] remains exactly as-is, except you no longer need to wait at the time specified by the plan waypoints given to the command handle. When you receive a new path, your robot can just follow the path all the way to the end. The waypoints given to the command handle will cut off at any waypoint that has a risk of leading into a conflict.

This PR depends on:

mxgrey added 20 commits March 6, 2022 18:08
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
… of time

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…veral hour test

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
aaronchongth
aaronchongth previously approved these changes Mar 20, 2022
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the same test scenarios without seeing any issues so far, this is awesome! LGTM

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@mxgrey mxgrey merged commit 7ed2196 into main Mar 20, 2022
@mxgrey mxgrey deleted the feature/traffic_event_system branch March 20, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants