Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for reporting status of perform_action #190

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Apr 5, 2022

This PR accomplishes three purposes:

  1. The task event status can now be updated by the action executor
  2. The action executor can now create event log entries
  3. The perform_action event status will automatically change to Completed when the action executor finishes

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@mxgrey
Copy link
Contributor Author

mxgrey commented Apr 5, 2022

Related to #170

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #190 (c09cda6) into main (4cf5d18) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   17.96%   17.89%   -0.07%     
==========================================
  Files         418      836     +418     
  Lines       38204    76492   +38288     
  Branches    18284    36604   +18320     
==========================================
+ Hits         6862    13691    +6829     
- Misses      24018    48146   +24128     
- Partials     7324    14655    +7331     
Flag Coverage Δ
tests 17.89% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../test/mock_monitor_nodes/missing_query_monitor.cpp
...ter/src/rmf_fleet_adapter/agv/test/MockAdapter.cpp
...-4.1.0/Rx/v2/src/rxcpp/operators/rx-start_with.hpp
...4.1.0/Rx/v2/src/rxcpp/schedulers/rx-sameworker.hpp
...mf_rxcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-predef.hpp
...adapter/src/rmf_fleet_adapter/phases/DoorClose.hpp
..._traffic_ros2/schedule/internal_convert_vector.hpp
..._traffic_ros2/schedule/convert_Inconsistencies.cpp
...f_ros2/rmf_task_ros2/test/bidding/test_SelfBid.cpp
...apter/src/rmf_fleet_adapter/events/ExecutePlan.cpp
... and 1244 more

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mxgrey mxgrey merged commit e9743b9 into main Apr 8, 2022
@mxgrey mxgrey deleted the perform_action_finish_and_error branch April 8, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants