Async behavior fixes #228
Merged
Async behavior fixes #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: youliang <tan_you_liang@hotmail.com>
…open-rmf/rmf_ros2 into feature/dispatcher-ws-broadcast
Signed-off-by: youliang <tan_you_liang@hotmail.com>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…nsive Signed-off-by: Michael X. Grey <grey@openrobotics.org>
xiyuoh
reviewed
Sep 11, 2022
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…ros2 into async_behavior_fixes
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
luca-della-vedova
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes many subtle issues related to async behaviors. Prior to this PR, there are many opportunities for race conditions to cause problematic outcomes, causing explosions in delay estimations, causing negotiations to hang permanently, or causing tasks to stop permanently with no recovery mechanism. There are also some memory consumption fixes in this PR, as there were a few ways in which the memory consumption of a fleet adapter would be able to grow indefinitely.
These issues should be fixed in this PR, confirmed by hours of intensive full-stack integration testing.
This PR depends on these other two:
CI won't be able to pass until those are merged.