Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable merge distances #289

Merged
merged 6 commits into from
Aug 14, 2023

Conversation

xiyuoh
Copy link
Member

@xiyuoh xiyuoh commented Jul 25, 2023

This PR supplements #286 to add a few more configurable parameters to the fleet adapter:

  • max_merge_waypoint_distance
  • max_merge_lane_distance
  • min_lane_length

As suggested, a default fleet value for each parameter can be configured in the fleet's config.yaml (example), and robot-specific distances can be set as well (example). To modify these values live, the EasyRobotUpdateHandle API is updated to accommodate getting and setting them.

These values are currently set independently since it might be more preferable to retrieve them individually, but I am wondering if it is better to take the params as optional values into a single function instead similar to RobotContext, such as

void EasyFullControl::EasyRobotUpdateHandle::set_nav_params(
  std::optional<double> max_merge_waypoint_distance,
  std::optional<double> max_merge_lane_distance,
  std::optional<double> min_lane_length)
{
  // modify value if has_value()
  // ...
  context->set_nav_params(new_nav_params);
}

Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
@xiyuoh xiyuoh requested a review from mxgrey July 25, 2023 09:00
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these parameters! We'll merge this in as soon as CI passes right away and let the CI run for the other PR.

@mxgrey mxgrey merged commit d732155 into reactive_easy_full_control Aug 14, 2023
2 of 4 checks passed
@mxgrey mxgrey deleted the xiyu/configurable_merge_distance branch August 14, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants