Improve linking time (#297) #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Signed-off-by: Michael X. Grey <grey@openrobotics.org> Co-authored-by: Luca Della Vedova <lucadv@intrinsic.ai>
mxgrey
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #297 to Iron.
Corresponding changes to
rmf_visualizationwere merged first open-rmf/rmf_visualization#63 and bloomed but a buildfarm error is reported related tormf_traffic_ros2targets https://build.ros2.org/job/Ibin_uJ64__rmf_visualization_schedule__ubuntu_jammy_amd64__binary/29/Github actions did not flag the issue since our reusable CI job always uses the
mainbranch ofrmf.reposfile. There is a PR open to switch the job to use the distro specific branch open-rmf/rmf_ci_templates#8Once this is merged, will bump version and bloom a release.