Adding reference_internal tag to function bindings that return raw pointers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchongth
force-pushed
the
fix/pybind_ptr_ownership
branch
from
e1079a5
to
267e8a8
Compare
Yadunund
previously approved these changes
Mar 11, 2021
…inters Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
force-pushed
the
fix/pybind_ptr_ownership
branch
from
267e8a8
to
9b04f8c
Compare
Yadunund
approved these changes
Mar 11, 2021
Yadunund
pushed a commit
that referenced
this pull request
Mar 19, 2021
…inters (#6) Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
pushed a commit
that referenced
this pull request
Mar 19, 2021
…inters (#6) Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
added a commit
that referenced
this pull request
Mar 19, 2021
* Added minimal api to generate plan Signed-off-by: Yadunund <yadunund@openrobotics.org> * Adding reference_internal tag to function bindings that return raw pointers (#6) Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Signed-off-by: Yadunund <yadunund@openrobotics.org> * planner binding returns waypoints in plan Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added use_sim_time function to Node Signed-off-by: Yadunund <yadunund@openrobotics.org> * get_plan_waypoints returns empty list if planner was unsuccessful Signed-off-by: Yadunund <yadunund@openrobotics.org> * Remove binding for interpolate options Signed-off-by: Yadunund <yadunund@openrobotics.org> Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
mxgrey
pushed a commit
that referenced
this pull request
Apr 22, 2021
* update gitignore * resolve lambda capture bug * refactor to follow ingestor api * update bindings for new Lane api * successful build for graph and lane api * update to use pybind11 2.6 * implement optionals * fix existing tests * removing optionals due to built in pybind11 support * remove compile_commands.json * formatting touch ups * appropriate handling of optionals * proposed modifications to test classes * update graph labelling * update constants to use enums directly * more descriptive assertions * add python bindings for mockadapter request_loop * split graph visualization into legend and graph * implement looprequest test * refactor into more reusable components * refactor further to separate tests logically * implement trace-style waypoint logs rather than count-style * remove unnecessary field * add teardown of nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Chong aaronchongth@gmail.com
Bug fix
Fixed bug
#4
Fix applied
The functions that were bound returns a raw pointer, using the fallback
return_value_policy::take_ownership, it deletes the item after it goes out of scope in python. Specifying them to usereturn_value_policy::reference_internalprevents that.