Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python binding planner #11

Merged
merged 6 commits into from
Mar 19, 2021
Merged

Conversation

Yadunund
Copy link
Member

New feature implementation

Implemented feature

Added additional python bindings:

  1. Minimal support for rmf_traffic::agv::Planner. A get_plan_waypoints function is implemented which returns a list of waypoints in the plan if the planner was successful.
  2. Updated the Node wrapper to allow users to set use_sim_time parameter to true. This is helpful for testing fleet adapters in simulation.

@Yadunund Yadunund assigned Yadunund and youliangtan and unassigned Yadunund Mar 18, 2021
// TODO
// Light wrappers
py::class_<Interpolate::Options>(m, "InterpolateOptions")
.def(py::init<>());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. One minor point, should we just remove binding for Interpolate::Options for now since it is not being used in the Configuration yet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done e9ecb82

youliangtan
youliangtan previously approved these changes Mar 18, 2021
Yadunund and others added 6 commits March 19, 2021 11:24
Signed-off-by: Yadunund <yadunund@openrobotics.org>
…inters (#6)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund force-pushed the feature/python_binding_planner branch from a1f7d4d to e059578 Compare March 19, 2021 03:25
@Yadunund Yadunund merged commit 61ca5ed into main Mar 19, 2021
@Yadunund Yadunund deleted the feature/python_binding_planner branch March 19, 2021 03:27
mxgrey pushed a commit that referenced this pull request Apr 22, 2021
* add api html docs and slight cleanup on readme

* change doc path to index.html

* update README

* Update shapes.cpp

* regenerate docs and fix test

* missing battery

* create adpt.schedule for particpant and traj

* add set_charger_wp()

* add update_idle_pos and lanes_from_waypoint

* add set_infinite_delay()

* fix nfn name of  set_infinite_delay()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants