Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find nearest waypoint for ResponsiveWait #98

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

Yadunund
Copy link
Member

Fix #97

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund added this to In Review in Research & Development via automation Aug 11, 2021
@Yadunund Yadunund requested a review from mxgrey August 11, 2021 14:57
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #98 (5605a36) into main (dbfdc87) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   22.02%   22.14%   +0.12%     
==========================================
  Files         410      615     +205     
  Lines       32882    49353   +16471     
  Branches    16044    24093    +8049     
==========================================
+ Hits         7243    10931    +3688     
- Misses      17828    26652    +8824     
- Partials     7811    11770    +3959     
Flag Coverage Δ
tests 22.14% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/rmf_fleet_adapter/jobs/detail/impl_Rollout.hpp
...eet_adapter/rmf_rxcpp/include/rmf_rxcpp/RxJobs.hpp
...t_adapter_python/graph/PyOrientationConstraint.hpp
..._fleet_adapter/src/rmf_fleet_adapter/ParseArgs.cpp
...mf_fleet_adapter/test/phases/test_DispenseItem.cpp
...mf_rxcpp/include/rmf_rxcpp/detail/RxJobsDetail.hpp
.../rmf_fleet_adapter/src/mock_traffic_light/main.cpp
...apter/src/rmf_fleet_adapter/phases/RequestLift.cpp
.../rmf_rxcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-util.hpp
...os2/rmf_traffic_ros2/examples/participant_node.cpp
... and 1015 more

@Yadunund
Copy link
Member Author

@mxgrey test_rmf_rxcpp seems to be failing in the galactic CI. Is it okay to merge as the changes here are not related to rmf_rxcpp?

@mxgrey
Copy link
Contributor

mxgrey commented Aug 18, 2021

Looks like the test passed in the original PR, but I agree that the changes in this PR couldn't have impacted the failure. I guess it's just a flaky test 😬 . We can merge this and deal with the bad test in a future PR.

@Yadunund Yadunund merged commit c21a685 into main Aug 18, 2021
@Yadunund Yadunund deleted the fix/nearest_waypoint_responsive_wait branch August 18, 2021 08:46
Research & Development automation moved this from In Review to Done Aug 18, 2021
arjo129 pushed a commit that referenced this pull request Oct 12, 2021
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Robot does not begin ResponsiveWait at nearest waypoint
2 participants