Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slotcar plugin package move #5

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Slotcar plugin package move #5

merged 3 commits into from
Apr 5, 2021

Conversation

gbiggs
Copy link
Collaborator

@gbiggs gbiggs commented Apr 3, 2021

Move the slotcar plugin from rmf_building_sim_* to rmf_robot_sim_*.

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
@gbiggs gbiggs added the enhancement New feature or request label Apr 3, 2021
@gbiggs gbiggs requested a review from Yadunund April 3, 2021 06:29
@gbiggs gbiggs self-assigned this Apr 3, 2021
@luca-della-vedova
Copy link
Member

I'm getting symbol lookup errors in ignition for compute_ds:

[ign-14] ign gazebo server: symbol lookup error: /home/luca/demos_ws/install/rmf_robot_sim_common/lib/libslotcar_common.so: undefined symbol: _ZN17rmf_plugins_utils10compute_dsEdddddd

Investigating a fix now

@luca-della-vedova
Copy link
Member

#6 fixes the startup crash, as well as cleaning up utils a bit

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova merged commit 5bae14d into main Apr 5, 2021
@luca-della-vedova luca-della-vedova deleted the slotcar-move branch April 5, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants