Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes and corrections to support ROS 2 Galactic #23

Merged
merged 2 commits into from Jun 4, 2021
Merged

Conversation

gbiggs
Copy link
Collaborator

@gbiggs gbiggs commented Jun 2, 2021

This PR provides the fixes necessary to compile and run with ROS 2 Galactic.

This PR is backwards-compatible with ROS 2 Foxy. It can be merged without impacting support for ROS 2 Foxy.

Part of open-rmf/rmf#60.

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
@gbiggs gbiggs added the enhancement New feature or request label Jun 2, 2021
@gbiggs gbiggs self-assigned this Jun 2, 2021
@gbiggs gbiggs added this to In Review in Research & Development via automation Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #23 (56785e3) into main (e711737) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #23     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files         90      46     -44     
  Lines       7480    3752   -3728     
=======================================
+ Misses      7480    3752   -3728     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...f_simulation/rmf_building_sim_common/src/utils.cpp
...uilding_sim_gazebo_plugins/src/toggle_charging.cpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
...building_sim_common/src/crowd_simulator_common.cpp
...rmf_building_sim_common/crowd_simulator_common.hpp
.../rmf_simulation/rmf_robot_sim_common/src/utils.cpp
...ation/rmf_robot_sim_common/src/ingestor_common.cpp
...ation/rmf_robot_sim_common/src/ingestor_common.cpp
...f_simulation/rmf_building_sim_common/src/utils.cpp
...tion/rmf_robot_sim_gazebo_plugins/src/readonly.cpp
... and 122 more

@marcoag marcoag self-requested a review June 3, 2021 08:37
@marcoag
Copy link
Member

marcoag commented Jun 3, 2021

LGTM!

@marcoag marcoag merged commit fb0f90f into main Jun 4, 2021
@marcoag marcoag deleted the geoff/galactic branch June 4, 2021 07:41
Research & Development automation moved this from In Review to Done Jun 4, 2021
@Yadunund Yadunund mentioned this pull request Jun 9, 2021
arjo129 pushed a commit that referenced this pull request Jun 10, 2021
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129 added a commit that referenced this pull request Jun 10, 2021
* Add support for ASAN address sanitizer

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Make it weekly instead.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Update to container tooling version

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Changes and corrections to support ROS 2 Galactic (#23)

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Update asan.yaml

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Changes for galactic (#25)

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Co-authored-by: Yadu <yadunund@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants