Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ASAN address sanitizer #24

Merged
merged 6 commits into from Jun 10, 2021
Merged

Add support for ASAN address sanitizer #24

merged 6 commits into from Jun 10, 2021

Conversation

arjo129
Copy link
Member

@arjo129 arjo129 commented Jun 2, 2021

much kwality... better sanity

Addresses: open-rmf/rmf#47

Adds support for address sanitizer for details see open-rmf/rmf_traffic#27.

ROS gpg keys broken in upstream image so will revisit when they are fixed.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #24 (c98b82b) into main (e711737) will not change coverage.
The diff coverage is n/a.

❗ Current head c98b82b differs from pull request most recent head 89d77dd. Consider uploading reports for the commit 89d77dd to get more accurate results

@@           Coverage Diff           @@
##            main     #24     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files         90      46     -44     
  Lines       7480    3752   -3728     
=======================================
+ Misses      7480    3752   -3728     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._robot_sim_gazebo_plugins/src/TeleportIngestor.cpp
...lation/rmf_building_sim_common/src/door_common.cpp
...ation/rmf_robot_sim_common/src/ingestor_common.cpp
..._building_sim_gazebo_plugins/src/toggle_floors.cpp
...building_sim_common/src/crowd_simulator_common.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.hpp
...tion/rmf_robot_sim_gazebo_plugins/src/readonly.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
... and 122 more

@luca-della-vedova luca-della-vedova self-requested a review June 8, 2021 00:49
@luca-della-vedova
Copy link
Member

Any idea why colcon is not finding the address sanitizer?

  /usr/bin/bash -c source /opt/ros/foxy/setup.sh && colcon build --event-handlers console_cohesion+ --packages-up-to rmf_building_sim_common rmf_building_sim_gazebo_plugins rmf_building_sim_ignition_plugins rmf_robot_sim_common rmf_robot_sim_gazebo_plugins rmf_robot_sim_ignition_plugins --symlink-install
  usage: colcon [-h] [--log-base LOG_BASE] [--log-level LOG_LEVEL]
                {build,coveragepy-result,extension-points,extensions,graph,info,lcov-result,list,metadata,mixin,test,test-result,version-check}
                ...
  colcon: error: Mixin 'asan' is not available for 'build'
Error: The process '/usr/bin/bash' failed with exit code 2

@arjo129
Copy link
Member Author

arjo129 commented Jun 8, 2021

This is something I'm still trying to figure out. Same config works in other repos. I probably should mark it with a WIP.

@arjo129 arjo129 changed the title Add support for ASAN address sanitizer [WIP] Add support for ASAN address sanitizer Jun 8, 2021
@arjo129 arjo129 changed the title [WIP] Add support for ASAN address sanitizer Add support for ASAN address sanitizer Jun 9, 2021
@arjo129
Copy link
Member Author

arjo129 commented Jun 9, 2021

@luca-della-vedova its ready. It was a really dumb mistake 🤦‍♂️ . Misspelled the mixin name.

arjo129 and others added 6 commits June 10, 2021 11:20
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@arjo129 arjo129 merged commit 3bb8cd2 into main Jun 10, 2021
@arjo129 arjo129 deleted the ci/asan branch June 10, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants