-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add markers, ackermann steering vehicles now use seperate motion function and final target yaw #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Works great thanks! Marking as draft so we can use it as a temporarily workaround until support for ackermann vehicles in rmf_traffic is finished |
…nt SL trajectory Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Closed via #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ddengster ed.fan@osrfoundation.org
Bug fix/Added Feature
Fixed bug
Using the previous
compute_ds
function with a smallers_target
(about15
) would result in a deceleration that was too large for the vehicle to move. The new functioncompute_ds_linear
uses an equation of motion that compute acceleration accordingly based off the remaining displacement, and current and target velocities.Using this function results in office robots not working correctly hence a new function; let it be a TODO for another day.Unified function in PR Make holonomic vehicles use new linear motion function #57Fixed bug with ackermann steering vehicles not moving when give a single straight line trajectory.
Added Feature
Add a property,
obey_target_yaw_ackermann
that allows vehicles to obey target yaw of the final waypoint of the trajectory. All ackermann steering robots can use this, it's set to false by default.Added markers for trajectory message's path
![image](https://user-images.githubusercontent.com/3326941/138247512-353d7820-e4cf-4d15-89a5-0efd07953338.png)