Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add markers, ackermann steering vehicles now use seperate motion function and final target yaw #54

Closed
wants to merge 10 commits into from

Conversation

ddengster
Copy link
Contributor

@ddengster ddengster commented Sep 29, 2021

Signed-off-by: ddengster ed.fan@osrfoundation.org

Bug fix/Added Feature

Fixed bug

  • Using the previous compute_ds function with a smaller s_target (about 15) would result in a deceleration that was too large for the vehicle to move. The new function compute_ds_linear uses an equation of motion that compute acceleration accordingly based off the remaining displacement, and current and target velocities. Using this function results in office robots not working correctly hence a new function; let it be a TODO for another day. Unified function in PR Make holonomic vehicles use new linear motion function #57

  • Fixed bug with ackermann steering vehicles not moving when give a single straight line trajectory.

Added Feature

Add a property, obey_target_yaw_ackermann that allows vehicles to obey target yaw of the final waypoint of the trajectory. All ackermann steering robots can use this, it's set to false by default.

Added markers for trajectory message's path
image

Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #54 (1cd58a6) into main (7e80608) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main     #54    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        138     138            
  Lines      12845   13329   +484     
======================================
- Misses     12845   13329   +484     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bot_sim_ignition_plugins/src/TeleportDispenser.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.cpp
...ion/rmf_building_sim_ignition_plugins/src/lift.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
...rmf_building_sim_common/crowd_simulator_common.hpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.hpp
...uilding_sim_gazebo_plugins/src/toggle_charging.cpp
...m_ignition_plugins/src/LightTuning/LightTuning.cpp
...ation/rmf_building_sim_gazebo_plugins/src/lift.cpp
...ation/rmf_building_sim_gazebo_plugins/src/door.cpp
... and 254 more

@luca-della-vedova luca-della-vedova marked this pull request as draft September 29, 2021 09:06
@luca-della-vedova
Copy link
Member

Works great thanks! Marking as draft so we can use it as a temporarily workaround until support for ackermann vehicles in rmf_traffic is finished

…nt SL trajectory

Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster ddengster changed the title ackermann steering vehicles now use seperate motion function ackermann steering vehicles now use seperate motion function and final target yaw Oct 18, 2021
@ddengster ddengster marked this pull request as ready for review October 19, 2021 03:11
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@ddengster ddengster changed the title ackermann steering vehicles now use seperate motion function and final target yaw add markers, ackermann steering vehicles now use seperate motion function and final target yaw Oct 21, 2021
@luca-della-vedova
Copy link
Member

Closed via #71

@luca-della-vedova luca-della-vedova deleted the fix/motion branch April 7, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants