Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make holonomic vehicles use new linear motion function #57

Closed
wants to merge 8 commits into from

Conversation

ddengster
Copy link
Contributor

@ddengster ddengster commented Oct 18, 2021

New feature implementation

Implemented feature/bugfix

With changes in #54 ackermann steering vehicles had to use a different motion function that takes advantage of a target speed. This PR makes diff drive vehicles make use of the same function as well without no-move bugs.

Relevant changes are in 38f4bcf, the rest of the commits are based off fix/motion. The changes are done in this separate PR because this could break many of our other simulations.

Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
…nt SL trajectory

Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #57 (38f4bcf) into main (5746ac7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #57       +/-   ##
==========================================
  Coverage    0.00%   0.00%               
==========================================
  Files        2118     138     -1980     
  Lines      203555   13185   -190370     
==========================================
+ Misses     203555   13185   -190370     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...f_simulation/rmf_building_sim_common/src/utils.cpp
...lding_sim_ignition_plugins/src/crowd_simulator.hpp
...robot_sim_gazebo_plugins/src/TeleportDispenser.cpp
...ing_sim_gazebo_plugins/src/thumbnail_generator.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
...building_sim_common/src/crowd_simulator_common.cpp
...ing_sim_gazebo_plugins/src/thumbnail_generator.cpp
...f_simulation/rmf_building_sim_common/src/utils.cpp
...tion/rmf_robot_sim_gazebo_plugins/src/readonly.cpp
.../rmf_simulation/rmf_robot_sim_common/src/utils.cpp
... and 2234 more

@luca-della-vedova
Copy link
Member

Closed via #71

@luca-della-vedova luca-della-vedova deleted the fix/unify_motion branch April 7, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants