Add missing buildtool_depend on cmake #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott K Logan <logans@cottsay.net>
|
This change should be backported to Humble. |
Yadunund
approved these changes
Dec 20, 2022
|
Thanks for the fix @cottsay. We've been using |
|
I targeted the branch that is listed in rosdistro: https://github.com/ros/rosdistro/blob/ef2141fa41fdc011b62017ac469dc3b23e6a5a4e/rolling/distribution.yaml#L3937 I didn't intend to do anything crazy here - sorry if that's not the right branch. |
Yadunund
pushed a commit
that referenced
this pull request
Apr 14, 2023
Signed-off-by: Scott K Logan <logans@cottsay.net> Signed-off-by: Scott K Logan <logans@cottsay.net>
mxgrey
pushed a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
These packages are missing buildtool dependencies. They're both declared as
cmakepackages, so they should declare a buildtool dependency on cmake to ensure that package is installed when building.This missing dependency was discovered when building debs for Rolling packages with
-DBUILD_TESTING=OFFand without test dependencies installed. It seems that once of those dependencies is indirectly ensuring thatcmakeis installed right now.Fix applied
Add
<buildtool_depend>cmake</buildtool_depend>to the package manifests.