-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the stubborn negotiator's strategy more flexible #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…fic into test/add_margins
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 32.66% 32.64% -0.03%
==========================================
Files 159 159
Lines 15655 15729 +74
Branches 10449 10489 +40
==========================================
+ Hits 5114 5134 +20
- Misses 1702 1736 +34
- Partials 8839 8859 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yadunund
previously approved these changes
Sep 1, 2021
rmf_traffic/include/rmf_traffic/schedule/StubbornNegotiator.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Yadunund
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StubbornNegotiator
negotiation strategy may be too rigid to be a good fit for some tricky circumstances. This PR provides more knobs to tailor the strategy of aStubbornNegotiator
to better suit various circumstances.These changes are particularly important if multiple read-only traffic participants need to co-exist in the same space. The new stubborn negotiation options allows conflicts between read-only participants to be resolved outside of RMF (e.g. by human operators) while still resolving any conflicts between the read-only and autonomous participants.