Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Odd design for large screens #1231

Closed
1 of 2 tasks
a0m0rajab opened this issue May 30, 2023 · 5 comments · Fixed by #1437
Closed
1 of 2 tasks

Feature: Odd design for large screens #1231

a0m0rajab opened this issue May 30, 2023 · 5 comments · Fixed by #1437
Labels
💡 feature good first issue Good for newcomers released on @beta released

Comments

@a0m0rajab
Copy link
Contributor

Type of feature

🎨 Style

Current behavior

When you are on large screen, the add to insights button and the table collabse.
image
a

Suggested solution

It would be great to keep the button visible

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@NsdHSO
Copy link
Contributor

NsdHSO commented Jun 9, 2023

@a0m0rajab I think the button is not visible because the table on lg screen of the container becomes a bad resolution
I think this issue can have a good-first-issuehttps://github.com/open-sauced/insights/blob/ede678b5624ec3a2406789e0a8dfec0880fd8080/components/organisms/Repositories/repositories.tsx#L97

@OgDev-01 OgDev-01 added good first issue Good for newcomers and removed 👀 needs triage labels Jul 25, 2023
@RitaDee
Copy link
Contributor

RitaDee commented Jul 26, 2023

Can I attend to this issue?

@RitaDee
Copy link
Contributor

RitaDee commented Jul 26, 2023

.take

@RitaDee RitaDee mentioned this issue Jul 26, 2023
Merged
19 tasks
@RitaDee RitaDee removed their assignment Jul 29, 2023
OgDev-01 pushed a commit that referenced this issue Jul 31, 2023
@RitaDee
fix: improve layout design for large screens #1231 (#1437)
d8ae808
github-actions bot pushed a commit that referenced this issue Jul 31, 2023
@RitaDee @open-sauced
chore(patch): release 1.58.0-beta.3 on beta channel [skip ci]
31a9a6a 
## [1.58.0-beta.3](v1.58.0-beta.2...v1.58.0-beta.3) (2023-07-31)

### 🐛 Bug Fixes

* improve layout design for large screens [#1231](#1231) ([#1437](#1437)) ([d8ae808](d8ae808))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.58.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Aug 2, 2023
@brandonroberts @open-sauced
chore(minor): release 1.58.0 [skip ci]
476c8a9 
## [1.58.0](v1.57.0...v1.58.0) (2023-08-02)

### 🧑‍💻 Code Refactoring

*  merge `authSession` function into `useSession` hook ([#1391](#1391)) ([d6c230d](d6c230d))

### 🎨 Styles

* add width and max width for created at in contributor-profile-tab ([#1429](#1429)) ([5614886](5614886))
* remove irrelevant padding in page divider ([#1427](#1427)) ([5faaa4e](5faaa4e))

### 🍕 Features

* add devcard button to user profile ([#1339](#1339)) ([6a1dbdc](6a1dbdc))
* new contributor highlight card ([#1443](#1443)) ([c88000b](c88000b))
* update redirect to feed page for unauthenticated users ([#1464](#1464)) ([6d8505f](6d8505f))

### 🐛 Bug Fixes

* add checkbox id name if not available based on label ([#1466](#1466)) ([68f66a7](68f66a7))
* add navigation to improve accessibility ([#1436](#1436)) ([d1d85f7](d1d85f7))
* contributor profile tab click state flicker ([#1432](#1432)) ([c9cf8ed](c9cf8ed))
* Deleted page button changed to delete highlight ([#1419](#1419)) ([d502605](d502605))
* fixed bug on chatbot button overlay ([#1420](#1420)) ([2a94583](2a94583))
* hide onboarding button on mobile ([#1460](#1460)) ([f63f240](f63f240))
* Improve Keyboard Accessibility for Notification Icon ([#1435](#1435)) ([05291c0](05291c0))
* improve layout design for large screens [#1231](#1231) ([#1437](#1437)) ([d8ae808](d8ae808))
* misaligned chat button close icon ([#1422](#1422)) ([60f22bd](60f22bd))
* mismatched selection color ([#1430](#1430)) ([8a1d37b](8a1d37b))
* reduce tab font size in contributors profile page ([#1413](#1413)) ([238dc2f](238dc2f))
* show repo filters on initial `feeds` route visit ([#1426](#1426)) ([833ee30](833ee30))
* tab inconsistency in user profile matching the url ([#1403](#1403)) ([f8c6766](f8c6766))
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This issue has been resolved in version 1.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 feature good first issue Good for newcomers released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve layout design for large screens #1231 RitaDee/insights
4 participants
@a0m0rajab @NsdHSO @OgDev-01 @RitaDee