fix: tab inconsistency in user profile matching the url #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
approved these changes
Jul 21, 2023
brandonroberts
requested changes
Jul 21, 2023
components/organisms/ContributorProfileTab/contributor-profile-tab.tsx
Outdated
Show resolved
Hide resolved
|
@OgDev-01 when I visit my profile that has highlights, I'm redirected to https://deploy-preview-1403--oss-insights.netlify.app/user/brandonroberts/highlights |
brandonroberts
approved these changes
Jul 24, 2023
This was happening because I didn’t update the |
bdougie
approved these changes
Jul 24, 2023
bdougie
changed the title
jpmcb
approved these changes
Jul 24, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
### [1.57.1-beta.2](v1.57.1-beta.1...v1.57.1-beta.2) (2023-07-24) ### 🐛 Bug Fixes * tab inconsistency in user profile matching the url ([#1403](#1403)) ([f8c6766](f8c6766))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
## [1.58.0](v1.57.0...v1.58.0) (2023-08-02) ### 🧑💻 Code Refactoring * merge `authSession` function into `useSession` hook ([#1391](#1391)) ([d6c230d](d6c230d)) ### 🎨 Styles * add width and max width for created at in contributor-profile-tab ([#1429](#1429)) ([5614886](5614886)) * remove irrelevant padding in page divider ([#1427](#1427)) ([5faaa4e](5faaa4e)) ### 🍕 Features * add devcard button to user profile ([#1339](#1339)) ([6a1dbdc](6a1dbdc)) * new contributor highlight card ([#1443](#1443)) ([c88000b](c88000b)) * update redirect to feed page for unauthenticated users ([#1464](#1464)) ([6d8505f](6d8505f)) ### 🐛 Bug Fixes * add checkbox id name if not available based on label ([#1466](#1466)) ([68f66a7](68f66a7)) * add navigation to improve accessibility ([#1436](#1436)) ([d1d85f7](d1d85f7)) * contributor profile tab click state flicker ([#1432](#1432)) ([c9cf8ed](c9cf8ed)) * Deleted page button changed to delete highlight ([#1419](#1419)) ([d502605](d502605)) * fixed bug on chatbot button overlay ([#1420](#1420)) ([2a94583](2a94583)) * hide onboarding button on mobile ([#1460](#1460)) ([f63f240](f63f240)) * Improve Keyboard Accessibility for Notification Icon ([#1435](#1435)) ([05291c0](05291c0)) * improve layout design for large screens [#1231](#1231) ([#1437](#1437)) ([d8ae808](d8ae808)) * misaligned chat button close icon ([#1422](#1422)) ([60f22bd](60f22bd)) * mismatched selection color ([#1430](#1430)) ([8a1d37b](8a1d37b)) * reduce tab font size in contributors profile page ([#1413](#1413)) ([238dc2f](238dc2f)) * show repo filters on initial `feeds` route visit ([#1426](#1426)) ([833ee30](833ee30)) * tab inconsistency in user profile matching the url ([#1403](#1403)) ([f8c6766](f8c6766))
|
🎉 This PR is included in version 1.58.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with tab inconsistency on the user profile page. Before now, when you visit a user profile with no highlights, the Highlights tab is active but hidden, leaving the contributors tab inactive but visible and blank.
This PR fixes the issue by making the
hasHighlightsvariable a state and updating the state with auseMemohook to prevent unnecessary rerendersWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1402
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2023-07-21.at.21.24.47.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?