Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misaligned chat close button icon #1422

Conversation

wasimapinjari
Copy link
Contributor

@wasimapinjari wasimapinjari commented Jul 25, 2023

Description

This PR fixes the issue of the misaligned chat close button icon. I also formatted the globals.css file better.

What type of PR is this?

  • πŸ› Bug Fix
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor

Related Tickets:

Fixes #1407

Desktop Screenshot:

255882448-7e652702-ad5c-4aee-ba47-5c1b0c606090

Added tests?

  • πŸ™… no, because they aren't needed

Added to documentation?

  • πŸ™… no documentation needed

@netlify
Copy link

netlify bot commented Jul 25, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit d7d5488
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64bfbf7f000bf800087c9868
😎 Deploy Preview https://deploy-preview-1422--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit d7d5488
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64bfbf7fc2c43d000747101f
😎 Deploy Preview https://deploy-preview-1422--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@wasimapinjari wasimapinjari changed the title misaligned chat close button icon fix fix: misaligned chat close button icon fix Jul 25, 2023
@wasimapinjari wasimapinjari changed the title fix: misaligned chat close button icon fix fix: misaligned chat close button icon Jul 25, 2023
Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great πŸ• ... Thanks for taking this on @wasimapinjari .
looking forward to seeing more of you awesome contributions 🀝

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OgDev-01 OgDev-01 merged commit 60f22bd into open-sauced:beta Jul 25, 2023
31 of 35 checks passed
@wasimapinjari wasimapinjari deleted the wasimapinjari/misaligned-chat-close-button-icon-fix branch July 25, 2023 14:02
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
### [1.57.1-beta.3](v1.57.1-beta.2...v1.57.1-beta.3) (2023-07-25)

### πŸ› Bug Fixes

* fixed bug on chatbot button overlay ([#1420](#1420)) ([2a94583](2a94583))
* misaligned chat button close icon ([#1422](#1422)) ([60f22bd](60f22bd))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.57.1-beta.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@wasimapinjari wasimapinjari restored the wasimapinjari/misaligned-chat-close-button-icon-fix branch July 25, 2023 14:07
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
## [1.58.0](v1.57.0...v1.58.0) (2023-08-02)

### πŸ§‘β€πŸ’» Code Refactoring

*  merge `authSession` function into `useSession` hook ([#1391](#1391)) ([d6c230d](d6c230d))

### 🎨 Styles

* add width and max width for created at in contributor-profile-tab ([#1429](#1429)) ([5614886](5614886))
* remove irrelevant padding in page divider ([#1427](#1427)) ([5faaa4e](5faaa4e))

### πŸ• Features

* add devcard button to user profile ([#1339](#1339)) ([6a1dbdc](6a1dbdc))
* new contributor highlight card ([#1443](#1443)) ([c88000b](c88000b))
* update redirect to feed page for unauthenticated users ([#1464](#1464)) ([6d8505f](6d8505f))

### πŸ› Bug Fixes

* add checkbox id name if not available based on label ([#1466](#1466)) ([68f66a7](68f66a7))
* add navigation to improve accessibility ([#1436](#1436)) ([d1d85f7](d1d85f7))
* contributor profile tab click state flicker ([#1432](#1432)) ([c9cf8ed](c9cf8ed))
* Deleted page button changed to delete highlight ([#1419](#1419)) ([d502605](d502605))
* fixed bug on chatbot button overlay ([#1420](#1420)) ([2a94583](2a94583))
* hide onboarding button on mobile ([#1460](#1460)) ([f63f240](f63f240))
* Improve Keyboard Accessibility for Notification Icon ([#1435](#1435)) ([05291c0](05291c0))
* improve layout design for large screens [#1231](#1231) ([#1437](#1437)) ([d8ae808](d8ae808))
* misaligned chat button close icon ([#1422](#1422)) ([60f22bd](60f22bd))
* mismatched selection color ([#1430](#1430)) ([8a1d37b](8a1d37b))
* reduce tab font size in contributors profile page ([#1413](#1413)) ([238dc2f](238dc2f))
* show repo filters on initial `feeds` route visit ([#1426](#1426)) ([833ee30](833ee30))
* tab inconsistency in user profile matching the url ([#1403](#1403)) ([f8c6766](f8c6766))
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

πŸŽ‰ This PR is included in version 1.58.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: misaligned chat close button icon
3 participants