Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Accepted PR and icon to reflect merged status #2041

Closed
BekahHW opened this issue Nov 2, 2023 · 7 comments · Fixed by #2057
Closed

Change Accepted PR and icon to reflect merged status #2041

BekahHW opened this issue Nov 2, 2023 · 7 comments · Fixed by #2057
Assignees

Comments

@BekahHW
Copy link
Member

BekahHW commented Nov 2, 2023

We currently have this in our insights overview:
Accepted PR

That number actually reflects Merged PRs. Let's change the text from Accepted PRs to Merged PRs, and update the icon to the merged icon:

merged icon.

If we don't currently have the icon in the repo, we'll need to add the svg first, and then replace the current icon.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@BekahHW BekahHW added the good first issue Good for newcomers label Nov 2, 2023
@itskish0re
Copy link
Contributor

.take

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor.

@amitsgh amitsgh removed their assignment Nov 6, 2023
@itskish0re
Copy link
Contributor

.take

Copy link
Contributor

open-sauced bot commented Nov 7, 2023

🎉 This issue has been resolved in version 1.74.0-beta.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Nov 7, 2023

🎉 This issue has been resolved in version 1.74.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Nov 9, 2023

🎉 This issue has been resolved in version 1.75.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants