You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current icons are inconsistent. They vary with stroke width, which makes it hard for developers to implement them without any back and forth from design.
Possible Solutions:
Try updating Octicons from v8 to v17 in React Icons. If that doesn't work... try solution 2
Install Octicons directly, and replace the icons.
Solution 01:
Note
Make sure to lock the version once it's updated, so it becomes future proof.
Check if there's a way to update Octicons version from v8 to v17 on React Iconspackage.json.
Import: eg: import {IssueOpenedIcon} from '@primer/octicons-react'
Replace old icons with Octicons
Context:
Currently React Icons uses v8 of Octicons and the latest version is v17. This means that there are several Octicons that is not available through React-Icons.
This issue is exploring the idea of using the Octicon package directly to get access to the latest Octicons.
It's looking better, but still, I think we should use the updated version of Octicons, because they will certainly render better.
Can we update the version we're using to be the latest?
I don't think we can update the current version of octicons that comes with react icons to the latest, except we create an issue requesting the update Here. But for now, Solution two is our best bet and I'll go with that on this issue 🙌
Summary
The current icons are inconsistent. They vary with stroke width, which makes it hard for developers to implement them without any back and forth from design.
Possible Solutions:
v8
tov17
in React Icons. If that doesn't work... try solution 2Solution 01:
v8
tov17
on React Iconspackage.json
.If that didn't work, use solution 2:
Solution 02:
Follow the steps here: https://primer.style/octicons/packages/react.
npm install @primer/octicons-react
import {IssueOpenedIcon} from '@primer/octicons-react'
Context:
Originally posted by @pixelsbyeryc in #243 (comment)
The text was updated successfully, but these errors were encountered: